-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filter
on <dom-repeat>
doesn't use JS filter syntax as specified in documentation
#3094
Comments
Closing per Polymer/old-docs-site#1381; website documentation is updated. See discussion on #2187 for background. |
When this was closed... the actual documentation in the code was not fixed. https://github.com/Polymer/polymer/blob/master/src/lib/template/dom-repeat.html#L161-L168 |
ktiedt
added a commit
to ktiedt/polymer
that referenced
this issue
Jul 22, 2016
Update the documentation in the actual dom-repeat element.
ktiedt
added a commit
to ktiedt/polymer
that referenced
this issue
Jul 22, 2016
Update the documentation in the actual dom-repeat element.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The documentation states
First of all it should probably state
callback function
instead ofsort function
. Secondly and more importantly the calls here and here miss theindex
andarray
arguments which one would expect onArray.filter
's callback function:Per https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/filter
And yes, this is extremely useful, as Polymer doesn't support
myArray.0
bindings right now, so anytime you need to do that you have to actually use adom-repeat
just to have the binding system work '-_- (and yes, I am aware ofarray-selector
but that would be even more confusing)The text was updated successfully, but these errors were encountered: