Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polymer 2.x allows observers to fire prior to all client dom being "ready" #4585

Closed
sorvell opened this issue May 5, 2017 · 0 comments
Closed

Polymer 2.x allows observers to fire prior to all client dom being "ready" #4585

sorvell opened this issue May 5, 2017 · 0 comments
Assignees
@sorvell
Labels
2.x p1

Comments

@sorvell
Copy link
Contributor

sorvell commented May 5, 2017

Polymer 1.x had a guarantee that should not change in Polymer 2.x, namely that client dom is "ready" when observers fire. This is currently not the case as demonstrated here (see console output).

http://jsbin.com/desohol/edit?html,output

We can address this by slighting changing how notifications are handled when a host has not initialized its client dom.
@sorvell sorvell self-assigned this May 5, 2017
sorvell pushed a commit that referenced this issue May 5, 2017
Fixes #4585. Data notifications do not flush host if host has not ini…
3b6981d 
…tialized clients. This preserves the Polymer 1.x guarantee that client dom is fully “readied” when data observers run.
@sorvell sorvell mentioned this issue May 5, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sorvell sorvell

Labels
2.x p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sorvell