Unique comp props #1243
Merged
Unique comp props #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 2, 2015 15:34
If multiple computed properties call the same method but with different
arguments, calls to the method are debounced because they pass the same
value as the task name. Rather than name the task only the method name,
use the full expression to let the developer ensure uniqueness.
Example:
```js
computed: {
foo: 'computeClassName(bar)',
baz: 'computeClassName(xyz)'
}
```
Currently they both create property effects wrapped in debounce calls
with task names of '_computeClassName':
```js
this.debounce('_computeClassName', function() { ... })
this.debounce('_computeClassName', function() { ... })
```
By passing the full expression rather than the method name, they result
in unique debounce task names:
```js
this.debounce('_computeClassName(bar)', function() { ... })
this.debounce('_computeClassName(xyz)', function() { ... })
```
Fixes #1242
The test fails without the other change in this branch.
|
+1 |
|
LGTM Thx! (will merge after conflicts are resolved) |
Conflicts: test/unit/bind-elements.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If multiple computed properties call the same method but with different
arguments, calls to the method are debounced because they pass the same
value as the task name. Rather than name the task only the method name,
use the full expression to let the developer ensure uniqueness.
Example:
Currently they both create property effects wrapped in debounce calls
with task names of '_computeClassName':
By passing the full expression rather than the method name, they result
in unique debounce task names: