Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare a batch of releases. #558

Merged
merged 2 commits into from
Jun 28, 2018
Merged

Prepare a batch of releases. #558

merged 2 commits into from
Jun 28, 2018

Conversation

aomarks
Copy link
Member

@aomarks aomarks commented Jun 28, 2018

  • dom5@3.0.1
  • @polymer/tools-common@2.0.1
  • polymer-analyzer@3.0.2
  • polymer-project-config@4.0.2
  • browser-capabilities@1.1.1
  • @polymer/esm-amd-loader@1.0.2
  • polymer-bundler@4.0.2
  • polymer-build@3.0.4
  • polyserve@0.27.12
  • wct-sauce@2.0.3
  • polymer-linter@3.0.1
  • polymer-editor-service@2.2.2
  • polymer-cli@1.7.7

@hastebrot
Copy link

No updated version of polyserve? I think it includes fixes to NPM warnings.

@aomarks
Copy link
Member Author

aomarks commented Jun 28, 2018

No updated version of polyserve? I think it includes fixes to NPM warnings.

Oh good point, I'll add the packages with NPM audit fixes. Was only looking at CHANGELOGs.

Copy link
Contributor

@usergenic usergenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aomarks aomarks merged commit e7ec974 into master Jun 28, 2018
@aomarks aomarks deleted the release branch June 28, 2018 20:50
@TimvdLippe
Copy link
Contributor

Awesome thanks!

@aomarks
Copy link
Member Author

aomarks commented Jun 28, 2018

All releases done! @TimvdLippe how are we looking with the NPM audit issues now?

@hastebrot
Copy link

hastebrot commented Jun 29, 2018

After the NPM packages with the NPM audit fixes were released yarn still complains. I wonder why this is, e.g. polyserve should automatically use the latest polymer-build release (with the audit fixes).

❯ yarn install
yarn install v1.7.0
info No lockfile found.
[1/4] 🔍  Resolving packages...
warning wct-browser-legacy > sinon > formatio@1.1.1: This package is unmaintained. Use @sinonjs/formatio instead
warning web-component-tester > sinon > formatio@1.2.0: This package is unmaintained. Use @sinonjs/formatio instead
warning web-component-tester > nomnom@1.8.1: Package no longer supported. Contact support@npmjs.com for more info.
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
warning "polyserve > polymer-build > @babel/plugin-transform-classes@7.0.0-beta.35" has incorrect peer dependency "@babel/core@7.0.0-beta.35".
warning "polyserve > polymer-project-config@4.0.2" has unmet peer dependency "polymer-analyzer@^3.0.1".
[4/4] 📃  Building fresh packages...
success Saved lockfile.

Update: Maybe this is also caused by my minimalistic setup (I only use polyserve and web-component-tester and wct-browser-legacy). When I also add polymer-analyzer one of the warnings goes away.

@TimvdLippe
Copy link
Contributor

@hastebrot wct-browser-legacy and web-component-tester still have vulnerabilities, I am working on fixing them.

@aomarks Audit issues in all other packages are resolved 🎉 However, the lockfiles are broken again, as the npm run nuke script is not working correctly. See #448 (comment) for the fix.

@web-padawan
Copy link
Contributor

@TimvdLippe can I ask you to also look at Polymer/polymer-modulizer#452 later if you have time?
It also contains a fix for some vulnerabilities issues in modulizer.

@TimvdLippe
Copy link
Contributor

@web-padawan I think we need to import modulizer in this repository to make this all a lot easier. Will ping the team to see what they think

@web-padawan
Copy link
Contributor

@TimvdLippe that's a valid point. I recall some PR to import polymer-workspaces (used by modulizer) which has been postponed.

At least it would be nice to have another modulizer release before importing it here, as there are at least 2 merged but not released fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants