Allow minify skipping by file glob. #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Westbrook merging this to a branch and updating goldens and adding regression test. |
|
🙏 hope I was taking it in a good direction. Thanks for picking this up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow JS files to be see as
isInline === falseso that they will skip the minifier.When working with a Polymer 2 project that includes the Firebase and PolymerFire code, the minification processing delivers those projects with errors. This can be avoided by not minifying those files. With the updates to support Polymer 3, all files were being viewed as
isInlineand as such were not being tested for whether they should or shouldn't be minified. This corrects the code order so that files that are notisInlinecan be seen as such and can be tested for exclusion from the minification pipeline.Fixes #279