Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

animateInitialSelection property brakes neon-animated-pages with the new iron-selector 1.0.8 #112

Closed
vguillou opened this issue Nov 24, 2015 · 5 comments

Comments

@vguillou
Copy link
Contributor

animateInitialSelection property brakes neon-animated-pages with the new iron-selector 1.0.8.

Expected outcome

The first page is animated upon entry when the animateInitialSelection property is set to true on the neon-animated-pages.

Actual outcome

The neon-animated-pages crashes 💥 and stays blank, no page can be displayed anymore :

neon-animated-pages.html:122 Uncaught TypeError: Cannot read property 'getAnimationConfig' of undefined

Steps to reproduce

  • Change the version of iron-selector int bower.json ("iron-selector": "PolymerElements/iron-selector#^1.0.8")
  • Run bower install
  • Pick a demo, add the animate-initial-selection attribute to the declared <neon-animated-pages>
  • Run the demo and voilà.

Full stacktrace

Uncaught TypeError: Cannot read property 'getAnimationConfig' of undefinedPolymer._selectedChanged @ neon-animated-pages.html:122
Polymer.Base.extend._complexObserverEffect @ polymer.html:1630
Polymer.Bind._modelApi._effectEffects @ polymer.html:1461
Polymer.Bind._modelApi._propertySetter @ polymer.html:1445
Polymer.Bind._modelApi.__setProperty @ polymer.html:1454
Polymer.Base._addFeature._applyConfig @ polymer.html:1997
Polymer.Base._addFeature._afterClientsReady @ polymer.html:1991
Polymer.Base._addFeature._ready @ polymer-mini.html:70
Polymer.Base._addFeature._readyClients @ polymer-mini.html:78
Polymer.Base._addFeature._ready @ polymer-mini.html:66
Polymer.Base._addFeature._tryReady @ polymer-mini.html:56
Polymer.Base._addFeature._initFeatures @ polymer.html:3497
Polymer.render @ polymer.html:4688
Polymer.attached @ polymer.html:4672
Polymer.Base._addFeature._invokeBehavior @ polymer-micro.html:392
Polymer.Base._addFeature._doBehavior @ polymer-micro.html:387
(anonymous function) @ polymer-micro.html:196
Polymer.RenderStatus.whenReady @ polymer-micro.html:110
Polymer.Base.attachedCallback @ polymer-micro.html:194
Polymer.Base._addFeature.attachedCallback @ polymer-mini.html:100
Polymer.Base._addFeature._readySelf @ polymer-mini.html:88
Polymer._ensureReady @ polymer.html:4630
Polymer._markImportsReady @ polymer.html:4635
(anonymous function) @ polymer.html:4625
Polymer.RenderStatus._makeReady @ polymer-micro.html:118
(anonymous function) @ polymer-micro.html:124
(anonymous function) @ timeline.js:21
@cdata
Copy link
Contributor

cdata commented Dec 10, 2015

Thanks for the detailed report. I will take a look.

@fooloomanzoo
Copy link

I get the same bug in my previous issue #83:

http://jsbin.com/jahoni/edit?html,console,output

if you leave out animate-initial-selection, the animation runs:

http://jsbin.com/gudedo/edit?html,console,output

@ozasadnyy
Copy link

Any ideas how to make it working?

@MeinAccount
Copy link

Try downgrading iron-selector to 1.0.7. (Add "iron-selector": "PolymerElements/iron-selector#1.0.7" as dependency in your bower.json.)

@ozasadnyy
Copy link

@MeinAccount yeah, it helps. Thanks!

vguillou added a commit to vguillou/neon-animation that referenced this issue Feb 23, 2016
Fixes PolymerElements#112 by listening to the ‘iron-selected’ event instead of the
‘selected-changed’.
This ensures that the initial event is fired after the pages are
initialized, thus allowing the element to retrieve the initially
selected page and animate it.
@vguillou vguillou mentioned this issue Feb 23, 2016
@cdata cdata closed this as completed in #144 Mar 7, 2016
cdata added a commit that referenced this issue Mar 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants