Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recipe2plan 2/n: Validate Handles, Tests #4834

Merged
merged 36 commits into from Mar 4, 2020
Merged

recipe2plan 2/n: Validate Handles, Tests #4834

merged 36 commits into from Mar 4, 2020

Commits on Feb 26, 2020

  1. creating structure of ts r2p script

    @alxmrs
    alxmrs committed Feb 26, 2020
    Copy the full SHA
    95a6488 View commit details
    Browse the repository at this point in the history

  2. Created fast CLI rapper for r2p script

    @alxmrs
    alxmrs committed Feb 26, 2020
    Copy the full SHA
    0a8ce91 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of github.com:PolymerLabs/arcs into r2p

    @alxmrs
    alxmrs committed Feb 26, 2020
    Copy the full SHA
    53c3df0 View commit details
    Browse the repository at this point in the history

  4. WIP figuring out ways to resolve a recipe

    @alxmrs
    alxmrs committed Feb 26, 2020
    Copy the full SHA
    1688a58 View commit details
    Browse the repository at this point in the history

  5. fix sp

    @alxmrs
    alxmrs committed Feb 26, 2020
    Copy the full SHA
    2c0763c View commit details
    Browse the repository at this point in the history

  6. Passing lint, still WIP

    @alxmrs
    alxmrs committed Feb 26, 2020
    Copy the full SHA
    f436bc6 View commit details
    Browse the repository at this point in the history

  7. Build macros for recipe2plan work

    @alxmrs
    alxmrs committed Feb 26, 2020
    Copy the full SHA
    6367335 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2020

  1. Lightweight iteration on recipe2plan, stubbed out tests

    @alxmrs
    alxmrs committed Feb 27, 2020
    Copy the full SHA
    b536cc0 View commit details
    Browse the repository at this point in the history

  2. Revised method to find corresponding create handles

    @alxmrs
    alxmrs committed Feb 27, 2020
    Copy the full SHA
    97f49b9 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2020

  1. Added type info

    @alxmrs
    alxmrs committed Feb 28, 2020
    Copy the full SHA
    d21a036 View commit details
    Browse the repository at this point in the history

  2. Added method to get all handles to manifest + get all handles by Id

    @alxmrs
    alxmrs committed Feb 28, 2020
    Copy the full SHA
    769e3e7 View commit details
    Browse the repository at this point in the history

  3. fix: no flatMap

    @alxmrs
    alxmrs committed Feb 28, 2020
    Copy the full SHA
    37e7e12 View commit details
    Browse the repository at this point in the history

  4. - currently, fails since it cannot find associated stores for handles.

    @alxmrs
    alxmrs committed Feb 28, 2020
    Copy the full SHA
    7f0da26 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2020

  1. uncleaned, but working recipe resolution

    @alxmrs
    alxmrs committed Mar 2, 2020
    Copy the full SHA
    db2367c View commit details
    Browse the repository at this point in the history

  2. Cleaned up for r2p, pt 1

    @alxmrs
    alxmrs committed Mar 2, 2020
    Copy the full SHA
    46091b3 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of github.com:PolymerLabs/arcs into r2p 

    # Conflicts:
#	src/runtime/manifest.ts
    @alxmrs
    alxmrs committed Mar 2, 2020
    Copy the full SHA
    2e7b9e9 View commit details
    Browse the repository at this point in the history

  4. stubbed out second test (short, short)

    @alxmrs
    alxmrs committed Mar 2, 2020
    Copy the full SHA
    b89809f View commit details
    Browse the repository at this point in the history

  5. Squashed commit of the following: 

    commit 62dcc57
Author: Alex Rosengarten <alxrsngrtn@google.com>
Date:   Mon Mar 2 14:38:14 2020 -0800

    Fixed test, added TODO
    @alxmrs
    alxmrs committed Mar 2, 2020
    Copy the full SHA
    282f8b4 View commit details
    Browse the repository at this point in the history

  6. updates to test, can't get two to fail

    @alxmrs
    alxmrs committed Mar 2, 2020
    Copy the full SHA
    6df9388 View commit details
    Browse the repository at this point in the history

  7. Squashed commit of the following: 

    commit bede8d9
Author: Alex Rosengarten <alxrsngrtn@google.com>
Date:   Mon Mar 2 14:52:02 2020 -0800

    Fixed build rule, simplified runtime

commit 62dcc57
Author: Alex Rosengarten <alxrsngrtn@google.com>
Date:   Mon Mar 2 14:38:14 2020 -0800

    Fixed test, added TODO
    @alxmrs
    alxmrs committed Mar 2, 2020
    Copy the full SHA
    47ae614 View commit details
    Browse the repository at this point in the history

  8. can't get test to fail... hmm...

    @alxmrs
    alxmrs committed Mar 2, 2020
    Copy the full SHA
    579b270 View commit details
    Browse the repository at this point in the history

  9. Squashed commit of the following: 

    commit f6df54a
Author: Alex Rosengarten <alxrsngrtn@google.com>
Date:   Mon Mar 2 15:44:32 2020 -0800

    tools/sigh lint

commit bede8d9
Author: Alex Rosengarten <alxrsngrtn@google.com>
Date:   Mon Mar 2 14:52:02 2020 -0800

    Fixed build rule, simplified runtime

commit 62dcc57
Author: Alex Rosengarten <alxrsngrtn@google.com>
Date:   Mon Mar 2 14:38:14 2020 -0800

    Fixed test, added TODO
    @alxmrs
    alxmrs committed Mar 2, 2020
    Copy the full SHA
    c4d973b View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' of github.com:PolymerLabs/arcs into r2p-tests

    @alxmrs
    alxmrs committed Mar 2, 2020
    Copy the full SHA
    e318016 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2020

  1. adjusting recipe copying to include triggers

    @alxmrs
    alxmrs committed Mar 3, 2020
    Copy the full SHA
    9bc3734 View commit details
    Browse the repository at this point in the history

  2. Revert "adjusting recipe copying to include triggers" 

    This reverts commit 9bc3734
    @alxmrs
    alxmrs committed Mar 3, 2020
    Copy the full SHA
    26fd66e View commit details
    Browse the repository at this point in the history

  3. four tests complete

    @alxmrs
    alxmrs committed Mar 3, 2020
    Copy the full SHA
    f764f1e View commit details
    Browse the repository at this point in the history

  4. Added test, fixed minor async issue

    @alxmrs
    alxmrs committed Mar 3, 2020
    Copy the full SHA
    389005e View commit details
    Browse the repository at this point in the history

  5. Squashed commit of the following: 

    commit 4b05a28
Merge: f4c1d26 99000c2
Author: Alex Rosengarten <alxrsngrtn@google.com>
Date:   Tue Mar 3 11:18:14 2020 -0800

    Merge branch 'r2p' of github.com:alxrsngrtn/arcs into r2p

commit f4c1d26
Merge: 140111f 5c6310d
Author: Alex Rosengarten <alxrsngrtn@google.com>
Date:   Tue Mar 3 11:14:35 2020 -0800

    Merge branch 'master' of github.com:PolymerLabs/arcs into r2p
    Fixed lint errors

commit 99000c2
Merge: 140111f 5c6310d
Author: Alex Rosengarten <alxrsngrtn@google.com>
Date:   Tue Mar 3 11:14:35 2020 -0800

    Merge branch 'master' of github.com:PolymerLabs/arcs into r2p
    Fixed lint errors

commit 140111f
Author: Alex Rosengarten <alxrsngrtn@google.com>
Date:   Tue Mar 3 11:08:12 2020 -0800

    Removed flatMap, added TODOs and link to GH issue

commit 5c6310d
Author: jblebrun <jibbl@google.com>
Date:   Tue Mar 3 11:02:34 2020 -0800

    Simplify service test pattern (PolymerLabs#4817)

    * Make a simple test lifecycle registry, instead of creating empty
    testactivity

    * Remove use of `runBlockingTest`: according to
    Kotlin/kotlinx.coroutines#1222, if the test
    results in coroutines being finished on other threads, it's possible to
    receive "This job has not yet completed" exceptions, even though the
    jobs were properly terminated. Since we don't need the delay-skipping
    properties of `runBlockingTest`, I think it's OK to use `runBlocking`.

commit 472bc84
Author: Alex Rosengarten <alxrsngrtn@google.com>
Date:   Tue Mar 3 10:27:56 2020 -0800

    Improved build rules

commit ca1ebf8
Author: Alex Rosengarten <alxrsngrtn@google.com>
Date:   Tue Mar 3 10:17:13 2020 -0800

    Impl suggestsions for r2p

commit b5578ea
Author: Jason Feinstein <jwf@google.com>
Date:   Tue Mar 3 09:54:17 2020 -0800

    Add tests for dereferencing references to the HandleManagerTest(s) (PolymerLabs#4816)

    * Add dereferencing tests to the android handle manager test.

    * Add dereferencing tests to core HandleManager.

commit a695797
Author: Jason Feinstein <jwf@google.com>
Date:   Mon Mar 2 18:14:07 2020 -0800

    Create RawEntityDereferencerTest, storage Reference-> CrdtEntity.Reference (PolymerLabs#4812)

    * Create RawEntityDereferencerTest, make storage Reference implement CrdtEntity.Reference.

    Also: Create ParcelableReference.

    * Add dep. Also, apparently read/writeBoolean is Q-only.

    * Just write null if there is no version map.

    * Just write null if there is no version map.

commit ba7a107
Author: Gogul Balakrishnan <bgogul@google.com>
Date:   Mon Mar 2 17:51:35 2020 -0800

    Add a decoder for PrimitiveTypeProto and an option to disable android constraints in BUILD. (PolymerLabs#4793)

commit f6df54a
Author: Alex Rosengarten <alxrsngrtn@google.com>
Date:   Mon Mar 2 15:44:32 2020 -0800

    tools/sigh lint

commit bede8d9
Author: Alex Rosengarten <alxrsngrtn@google.com>
Date:   Mon Mar 2 14:52:02 2020 -0800

    Fixed build rule, simplified runtime

commit 62dcc57
Author: Alex Rosengarten <alxrsngrtn@google.com>
Date:   Mon Mar 2 14:38:14 2020 -0800

    Fixed test, added TODO
    @alxmrs
    alxmrs committed Mar 3, 2020
    Copy the full SHA
    e5af675 View commit details
    Browse the repository at this point in the history

  6. fix ineq

    @alxmrs
    alxmrs committed Mar 3, 2020
    Copy the full SHA
    517a208 View commit details
    Browse the repository at this point in the history

  7. existing tests passing

    @alxmrs
    alxmrs committed Mar 3, 2020
    Copy the full SHA
    377d2d5 View commit details
    Browse the repository at this point in the history

  8. Updating invalid type test

    @alxmrs
    alxmrs committed Mar 3, 2020
    Copy the full SHA
    2e299ab View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2020

  1. Squashed commit of the following: 

    commit b3d92d0
Author: Alex Rosengarten <alxrsngrtn@google.com>
Date:   Wed Mar 4 12:17:17 2020 -0800

    updated test name

commit ba7884b
Author: Alex Rosengarten <alxrsngrtn@google.com>
Date:   Wed Mar 4 12:16:09 2020 -0800

    nested unit tests

commit ef36fdf
Author: Alex Rosengarten <alxrsngrtn@google.com>
Date:   Wed Mar 4 12:15:00 2020 -0800

    renamed to tryResolve

commit 5703f02
Author: Alex Rosengarten <alxrsngrtn@google.com>
Date:   Wed Mar 4 12:07:18 2020 -0800

    rm generator

commit 658cb1a
Author: Alex Rosengarten <alxrsngrtn@google.com>
Date:   Wed Mar 4 12:01:54 2020 -0800

    implemented more review suggestions

commit 0056ee3
Merge: cae89c3 0f0f82a
Author: Alex Rosengarten <alxrsngrtn@google.com>
Date:   Wed Mar 4 11:54:23 2020 -0800

    Merge branch 'master' of github.com:PolymerLabs/arcs into r2p

commit 0f0f82a
Author: Maria Mandlis <mmandlis@chromium.org>
Date:   Wed Mar 4 09:33:29 2020 -0800

    add queryable capability (PolymerLabs#4794)

commit d032c75
Author: Maria Mandlis <mmandlis@chromium.org>
Date:   Wed Mar 4 09:23:07 2020 -0800

    add creatimeTimestamp to entities (kt) (PolymerLabs#4823)

commit 30267fc
Author: jblebrun <jibbl@google.com>
Date:   Wed Mar 4 09:09:39 2020 -0800

    Remove some unused deps (PolymerLabs#4831)

commit c519181
Author: Cameron Silvestrini <csilvestrini@users.noreply.github.com>
Date:   Wed Mar 4 17:14:07 2020 +1100

    Increase size of DatabaseImplTest to medium (PolymerLabs#4827)

    * Increase size of DatabaseImplTest to medium

    Was a bit flaky.

    * Check flakiness

    * Revert presubmit tweak

commit fa621c6
Author: jblebrun <jibbl@google.com>
Date:   Tue Mar 3 22:05:07 2020 -0800

    Fix a race condition when setting up `ServiceStore` message channel (PolymerLabs#4826)

    This seems to be the cause of the flakiness in `AndroidAllocatorTest`
    and `AndroidHandleManagerTest` (PolymerLabs#4781)

commit 78bf4f0
Author: Gogul Balakrishnan <bgogul@google.com>
Date:   Tue Mar 3 18:00:49 2020 -0800

    Utility to convert type proto to field type (if possible). (PolymerLabs#4814)

commit cae89c3
Merge: 0360752 e587539
Author: Alex Rosengarten <alxrsngrtn@google.com>
Date:   Tue Mar 3 15:50:34 2020 -0800

    Merge branch 'master' of github.com:PolymerLabs/arcs into r2p

commit e587539
Author: jblebrun <jibbl@google.com>
Date:   Tue Mar 3 15:07:16 2020 -0800

    Apply simplified test pattern tests in `arcs.android.host` (PolymerLabs#4821)

    As in 5c6310d

commit 1af1aac
Author: Joshua Pratt <jp10010101010000@gmail.com>
Date:   Wed Mar 4 09:48:15 2020 +1100

    Multinomials (PolymerLabs#4804)

    * multinomial

    * added tests

    * making constant readable again

    * reindent

    * added multivariate rearrangement tests

    * updated comment

    * pr comments:

    Co-authored-by: Ragav Sachdeva <ragavsachdeva007@gmail.com>

commit 0360752
Author: Alex Rosengarten <alxrsngrtn@google.com>
Date:   Tue Mar 3 11:42:31 2020 -0800

    fix, bad comparison op

commit 4b05a28
Merge: f4c1d26 99000c2
Author: Alex Rosengarten <alxrsngrtn@google.com>
Date:   Tue Mar 3 11:18:14 2020 -0800

    Merge branch 'r2p' of github.com:alxrsngrtn/arcs into r2p

commit f4c1d26
Merge: 140111f 5c6310d
Author: Alex Rosengarten <alxrsngrtn@google.com>
Date:   Tue Mar 3 11:14:35 2020 -0800

    Merge branch 'master' of github.com:PolymerLabs/arcs into r2p
    Fixed lint errors

commit 99000c2
Merge: 140111f 5c6310d
Author: Alex Rosengarten <alxrsngrtn@google.com>
Date:   Tue Mar 3 11:14:35 2020 -0800

    Merge branch 'master' of github.com:PolymerLabs/arcs into r2p
    Fixed lint errors

commit 140111f
Author: Alex Rosengarten <alxrsngrtn@google.com>
Date:   Tue Mar 3 11:08:12 2020 -0800

    Removed flatMap, added TODOs and link to GH issue

commit 5c6310d
Author: jblebrun <jibbl@google.com>
Date:   Tue Mar 3 11:02:34 2020 -0800

    Simplify service test pattern (PolymerLabs#4817)

    * Make a simple test lifecycle registry, instead of creating empty
    testactivity

    * Remove use of `runBlockingTest`: according to
    Kotlin/kotlinx.coroutines#1222, if the test
    results in coroutines being finished on other threads, it's possible to
    receive "This job has not yet completed" exceptions, even though the
    jobs were properly terminated. Since we don't need the delay-skipping
    properties of `runBlockingTest`, I think it's OK to use `runBlocking`.

commit 472bc84
Author: Alex Rosengarten <alxrsngrtn@google.com>
Date:   Tue Mar 3 10:27:56 2020 -0800

    Improved build rules

commit ca1ebf8
Author: Alex Rosengarten <alxrsngrtn@google.com>
Date:   Tue Mar 3 10:17:13 2020 -0800

    Impl suggestsions for r2p

commit b5578ea
Author: Jason Feinstein <jwf@google.com>
Date:   Tue Mar 3 09:54:17 2020 -0800

    Add tests for dereferencing references to the HandleManagerTest(s) (PolymerLabs#4816)

    * Add dereferencing tests to the android handle manager test.

    * Add dereferencing tests to core HandleManager.

commit a695797
Author: Jason Feinstein <jwf@google.com>
Date:   Mon Mar 2 18:14:07 2020 -0800

    Create RawEntityDereferencerTest, storage Reference-> CrdtEntity.Reference (PolymerLabs#4812)

    * Create RawEntityDereferencerTest, make storage Reference implement CrdtEntity.Reference.

    Also: Create ParcelableReference.

    * Add dep. Also, apparently read/writeBoolean is Q-only.

    * Just write null if there is no version map.

    * Just write null if there is no version map.

commit ba7a107
Author: Gogul Balakrishnan <bgogul@google.com>
Date:   Mon Mar 2 17:51:35 2020 -0800

    Add a decoder for PrimitiveTypeProto and an option to disable android constraints in BUILD. (PolymerLabs#4793)

commit f6df54a
Author: Alex Rosengarten <alxrsngrtn@google.com>
Date:   Mon Mar 2 15:44:32 2020 -0800

    tools/sigh lint

commit bede8d9
Author: Alex Rosengarten <alxrsngrtn@google.com>
Date:   Mon Mar 2 14:52:02 2020 -0800

    Fixed build rule, simplified runtime

commit 62dcc57
Author: Alex Rosengarten <alxrsngrtn@google.com>
Date:   Mon Mar 2 14:38:14 2020 -0800

    Fixed test, added TODO
    @alxmrs
    alxmrs committed Mar 4, 2020
    Copy the full SHA
    5eb364c View commit details
    Browse the repository at this point in the history

  2. fixed nested tests

    @alxmrs
    alxmrs committed Mar 4, 2020
    Copy the full SHA
    b9d016a View commit details
    Browse the repository at this point in the history

  3. rewording, reorganizing

    @alxmrs
    alxmrs committed Mar 4, 2020
    Copy the full SHA
    6ada943 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' of github.com:PolymerLabs/arcs into r2p-tests

    @alxmrs
    alxmrs committed Mar 4, 2020
    Copy the full SHA
    7256197 View commit details
    Browse the repository at this point in the history

  5. assert more ergonomic

    @alxmrs
    alxmrs committed Mar 4, 2020
    Copy the full SHA
    9745c17 View commit details
    Browse the repository at this point in the history