recipe2plan 2/n: Validate Handles, Tests #4834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/runtime/manifest.ts
commit 62dcc57 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 14:38:14 2020 -0800 Fixed test, added TODO
commit f6df54a Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 15:44:32 2020 -0800 tools/sigh lint commit bede8d9 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 14:52:02 2020 -0800 Fixed build rule, simplified runtime commit 62dcc57 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 14:38:14 2020 -0800 Fixed test, added TODO
This reverts commit 9bc3734
commit 4b05a28 Merge: f4c1d26 99000c2 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 11:18:14 2020 -0800 Merge branch 'r2p' of github.com:alxrsngrtn/arcs into r2p commit f4c1d26 Merge: 140111f 5c6310d Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 11:14:35 2020 -0800 Merge branch 'master' of github.com:PolymerLabs/arcs into r2p Fixed lint errors commit 99000c2 Merge: 140111f 5c6310d Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 11:14:35 2020 -0800 Merge branch 'master' of github.com:PolymerLabs/arcs into r2p Fixed lint errors commit 140111f Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 11:08:12 2020 -0800 Removed flatMap, added TODOs and link to GH issue commit 5c6310d Author: jblebrun <jibbl@google.com> Date: Tue Mar 3 11:02:34 2020 -0800 Simplify service test pattern (PolymerLabs#4817) * Make a simple test lifecycle registry, instead of creating empty testactivity * Remove use of `runBlockingTest`: according to Kotlin/kotlinx.coroutines#1222, if the test results in coroutines being finished on other threads, it's possible to receive "This job has not yet completed" exceptions, even though the jobs were properly terminated. Since we don't need the delay-skipping properties of `runBlockingTest`, I think it's OK to use `runBlocking`. commit 472bc84 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 10:27:56 2020 -0800 Improved build rules commit ca1ebf8 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 10:17:13 2020 -0800 Impl suggestsions for r2p commit b5578ea Author: Jason Feinstein <jwf@google.com> Date: Tue Mar 3 09:54:17 2020 -0800 Add tests for dereferencing references to the HandleManagerTest(s) (PolymerLabs#4816) * Add dereferencing tests to the android handle manager test. * Add dereferencing tests to core HandleManager. commit a695797 Author: Jason Feinstein <jwf@google.com> Date: Mon Mar 2 18:14:07 2020 -0800 Create RawEntityDereferencerTest, storage Reference-> CrdtEntity.Reference (PolymerLabs#4812) * Create RawEntityDereferencerTest, make storage Reference implement CrdtEntity.Reference. Also: Create ParcelableReference. * Add dep. Also, apparently read/writeBoolean is Q-only. * Just write null if there is no version map. * Just write null if there is no version map. commit ba7a107 Author: Gogul Balakrishnan <bgogul@google.com> Date: Mon Mar 2 17:51:35 2020 -0800 Add a decoder for PrimitiveTypeProto and an option to disable android constraints in BUILD. (PolymerLabs#4793) commit f6df54a Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 15:44:32 2020 -0800 tools/sigh lint commit bede8d9 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 14:52:02 2020 -0800 Fixed build rule, simplified runtime commit 62dcc57 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 14:38:14 2020 -0800 Fixed test, added TODO
commit b3d92d0 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 12:17:17 2020 -0800 updated test name commit ba7884b Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 12:16:09 2020 -0800 nested unit tests commit ef36fdf Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 12:15:00 2020 -0800 renamed to tryResolve commit 5703f02 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 12:07:18 2020 -0800 rm generator commit 658cb1a Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 12:01:54 2020 -0800 implemented more review suggestions commit 0056ee3 Merge: cae89c3 0f0f82a Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 11:54:23 2020 -0800 Merge branch 'master' of github.com:PolymerLabs/arcs into r2p commit 0f0f82a Author: Maria Mandlis <mmandlis@chromium.org> Date: Wed Mar 4 09:33:29 2020 -0800 add queryable capability (PolymerLabs#4794) commit d032c75 Author: Maria Mandlis <mmandlis@chromium.org> Date: Wed Mar 4 09:23:07 2020 -0800 add creatimeTimestamp to entities (kt) (PolymerLabs#4823) commit 30267fc Author: jblebrun <jibbl@google.com> Date: Wed Mar 4 09:09:39 2020 -0800 Remove some unused deps (PolymerLabs#4831) commit c519181 Author: Cameron Silvestrini <csilvestrini@users.noreply.github.com> Date: Wed Mar 4 17:14:07 2020 +1100 Increase size of DatabaseImplTest to medium (PolymerLabs#4827) * Increase size of DatabaseImplTest to medium Was a bit flaky. * Check flakiness * Revert presubmit tweak commit fa621c6 Author: jblebrun <jibbl@google.com> Date: Tue Mar 3 22:05:07 2020 -0800 Fix a race condition when setting up `ServiceStore` message channel (PolymerLabs#4826) This seems to be the cause of the flakiness in `AndroidAllocatorTest` and `AndroidHandleManagerTest` (PolymerLabs#4781) commit 78bf4f0 Author: Gogul Balakrishnan <bgogul@google.com> Date: Tue Mar 3 18:00:49 2020 -0800 Utility to convert type proto to field type (if possible). (PolymerLabs#4814) commit cae89c3 Merge: 0360752 e587539 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 15:50:34 2020 -0800 Merge branch 'master' of github.com:PolymerLabs/arcs into r2p commit e587539 Author: jblebrun <jibbl@google.com> Date: Tue Mar 3 15:07:16 2020 -0800 Apply simplified test pattern tests in `arcs.android.host` (PolymerLabs#4821) As in 5c6310d commit 1af1aac Author: Joshua Pratt <jp10010101010000@gmail.com> Date: Wed Mar 4 09:48:15 2020 +1100 Multinomials (PolymerLabs#4804) * multinomial * added tests * making constant readable again * reindent * added multivariate rearrangement tests * updated comment * pr comments: Co-authored-by: Ragav Sachdeva <ragavsachdeva007@gmail.com> commit 0360752 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 11:42:31 2020 -0800 fix, bad comparison op commit 4b05a28 Merge: f4c1d26 99000c2 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 11:18:14 2020 -0800 Merge branch 'r2p' of github.com:alxrsngrtn/arcs into r2p commit f4c1d26 Merge: 140111f 5c6310d Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 11:14:35 2020 -0800 Merge branch 'master' of github.com:PolymerLabs/arcs into r2p Fixed lint errors commit 99000c2 Merge: 140111f 5c6310d Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 11:14:35 2020 -0800 Merge branch 'master' of github.com:PolymerLabs/arcs into r2p Fixed lint errors commit 140111f Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 11:08:12 2020 -0800 Removed flatMap, added TODOs and link to GH issue commit 5c6310d Author: jblebrun <jibbl@google.com> Date: Tue Mar 3 11:02:34 2020 -0800 Simplify service test pattern (PolymerLabs#4817) * Make a simple test lifecycle registry, instead of creating empty testactivity * Remove use of `runBlockingTest`: according to Kotlin/kotlinx.coroutines#1222, if the test results in coroutines being finished on other threads, it's possible to receive "This job has not yet completed" exceptions, even though the jobs were properly terminated. Since we don't need the delay-skipping properties of `runBlockingTest`, I think it's OK to use `runBlocking`. commit 472bc84 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 10:27:56 2020 -0800 Improved build rules commit ca1ebf8 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 10:17:13 2020 -0800 Impl suggestsions for r2p commit b5578ea Author: Jason Feinstein <jwf@google.com> Date: Tue Mar 3 09:54:17 2020 -0800 Add tests for dereferencing references to the HandleManagerTest(s) (PolymerLabs#4816) * Add dereferencing tests to the android handle manager test. * Add dereferencing tests to core HandleManager. commit a695797 Author: Jason Feinstein <jwf@google.com> Date: Mon Mar 2 18:14:07 2020 -0800 Create RawEntityDereferencerTest, storage Reference-> CrdtEntity.Reference (PolymerLabs#4812) * Create RawEntityDereferencerTest, make storage Reference implement CrdtEntity.Reference. Also: Create ParcelableReference. * Add dep. Also, apparently read/writeBoolean is Q-only. * Just write null if there is no version map. * Just write null if there is no version map. commit ba7a107 Author: Gogul Balakrishnan <bgogul@google.com> Date: Mon Mar 2 17:51:35 2020 -0800 Add a decoder for PrimitiveTypeProto and an option to disable android constraints in BUILD. (PolymerLabs#4793) commit f6df54a Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 15:44:32 2020 -0800 tools/sigh lint commit bede8d9 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 14:52:02 2020 -0800 Fixed build rule, simplified runtime commit 62dcc57 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 14:38:14 2020 -0800 Fixed test, added TODO
piotrswigon
reviewed
Mar 4, 2020
piotrswigon
approved these changes
Mar 4, 2020
|
Good to have tests :) |
alxmrs
added a commit
to alxmrs/arcs
that referenced
this pull request
Mar 5, 2020
commit 17a2ab1 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 16:30:45 2020 -0800 Fixed indentation commit 9094055 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 16:03:51 2020 -0800 revising from feedback commit d350821 Merge: 9054c23 3acb7e7 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 15:56:55 2020 -0800 Merge branch 'master' of github.com:PolymerLabs/arcs into s2k-schemas commit 3acb7e7 Author: Alex Rosengarten <alxr@google.com> Date: Wed Mar 4 15:56:42 2020 -0800 XXS CL to add a hash field to the Schema proto (PolymerLabs#4752) commit 9054c23 Merge: d15008e 337b7b2 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 15:55:27 2020 -0800 Merge branch 'master' of github.com:PolymerLabs/arcs into s2k-schemas commit 337b7b2 Author: Alex Rosengarten <alxr@google.com> Date: Wed Mar 4 15:55:06 2020 -0800 recipe2plan 2/n: Validate Handles, Tests (PolymerLabs#4834) * creating structure of ts r2p script * Created fast CLI rapper for r2p script * WIP figuring out ways to resolve a recipe * fix sp * Passing lint, still WIP * Build macros for recipe2plan work * Lightweight iteration on recipe2plan, stubbed out tests * Revised method to find corresponding create handles * Added type info * Added method to get all handles to manifest + get all handles by Id * fix: no flatMap * - currently, fails since it cannot find associated stores for handles. * uncleaned, but working recipe resolution * Cleaned up for r2p, pt 1 * stubbed out second test (short, short) * Squashed commit of the following: commit 62dcc57 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 14:38:14 2020 -0800 Fixed test, added TODO * updates to test, can't get two to fail * Squashed commit of the following: commit bede8d9 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 14:52:02 2020 -0800 Fixed build rule, simplified runtime commit 62dcc57 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 14:38:14 2020 -0800 Fixed test, added TODO * can't get test to fail... hmm... * Squashed commit of the following: commit f6df54a Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 15:44:32 2020 -0800 tools/sigh lint commit bede8d9 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 14:52:02 2020 -0800 Fixed build rule, simplified runtime commit 62dcc57 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 14:38:14 2020 -0800 Fixed test, added TODO * adjusting recipe copying to include triggers * Revert "adjusting recipe copying to include triggers" This reverts commit 9bc3734 * four tests complete * Added test, fixed minor async issue * Squashed commit of the following: commit 4b05a28 Merge: f4c1d26 99000c2 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 11:18:14 2020 -0800 Merge branch 'r2p' of github.com:alxrsngrtn/arcs into r2p commit f4c1d26 Merge: 140111f 5c6310d Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 11:14:35 2020 -0800 Merge branch 'master' of github.com:PolymerLabs/arcs into r2p Fixed lint errors commit 99000c2 Merge: 140111f 5c6310d Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 11:14:35 2020 -0800 Merge branch 'master' of github.com:PolymerLabs/arcs into r2p Fixed lint errors commit 140111f Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 11:08:12 2020 -0800 Removed flatMap, added TODOs and link to GH issue commit 5c6310d Author: jblebrun <jibbl@google.com> Date: Tue Mar 3 11:02:34 2020 -0800 Simplify service test pattern (PolymerLabs#4817) * Make a simple test lifecycle registry, instead of creating empty testactivity * Remove use of `runBlockingTest`: according to Kotlin/kotlinx.coroutines#1222, if the test results in coroutines being finished on other threads, it's possible to receive "This job has not yet completed" exceptions, even though the jobs were properly terminated. Since we don't need the delay-skipping properties of `runBlockingTest`, I think it's OK to use `runBlocking`. commit 472bc84 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 10:27:56 2020 -0800 Improved build rules commit ca1ebf8 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 10:17:13 2020 -0800 Impl suggestsions for r2p commit b5578ea Author: Jason Feinstein <jwf@google.com> Date: Tue Mar 3 09:54:17 2020 -0800 Add tests for dereferencing references to the HandleManagerTest(s) (PolymerLabs#4816) * Add dereferencing tests to the android handle manager test. * Add dereferencing tests to core HandleManager. commit a695797 Author: Jason Feinstein <jwf@google.com> Date: Mon Mar 2 18:14:07 2020 -0800 Create RawEntityDereferencerTest, storage Reference-> CrdtEntity.Reference (PolymerLabs#4812) * Create RawEntityDereferencerTest, make storage Reference implement CrdtEntity.Reference. Also: Create ParcelableReference. * Add dep. Also, apparently read/writeBoolean is Q-only. * Just write null if there is no version map. * Just write null if there is no version map. commit ba7a107 Author: Gogul Balakrishnan <bgogul@google.com> Date: Mon Mar 2 17:51:35 2020 -0800 Add a decoder for PrimitiveTypeProto and an option to disable android constraints in BUILD. (PolymerLabs#4793) commit f6df54a Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 15:44:32 2020 -0800 tools/sigh lint commit bede8d9 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 14:52:02 2020 -0800 Fixed build rule, simplified runtime commit 62dcc57 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 14:38:14 2020 -0800 Fixed test, added TODO * fix ineq * existing tests passing * Updating invalid type test * Squashed commit of the following: commit b3d92d0 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 12:17:17 2020 -0800 updated test name commit ba7884b Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 12:16:09 2020 -0800 nested unit tests commit ef36fdf Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 12:15:00 2020 -0800 renamed to tryResolve commit 5703f02 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 12:07:18 2020 -0800 rm generator commit 658cb1a Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 12:01:54 2020 -0800 implemented more review suggestions commit 0056ee3 Merge: cae89c3 0f0f82a Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 11:54:23 2020 -0800 Merge branch 'master' of github.com:PolymerLabs/arcs into r2p commit 0f0f82a Author: Maria Mandlis <mmandlis@chromium.org> Date: Wed Mar 4 09:33:29 2020 -0800 add queryable capability (PolymerLabs#4794) commit d032c75 Author: Maria Mandlis <mmandlis@chromium.org> Date: Wed Mar 4 09:23:07 2020 -0800 add creatimeTimestamp to entities (kt) (PolymerLabs#4823) commit 30267fc Author: jblebrun <jibbl@google.com> Date: Wed Mar 4 09:09:39 2020 -0800 Remove some unused deps (PolymerLabs#4831) commit c519181 Author: Cameron Silvestrini <csilvestrini@users.noreply.github.com> Date: Wed Mar 4 17:14:07 2020 +1100 Increase size of DatabaseImplTest to medium (PolymerLabs#4827) * Increase size of DatabaseImplTest to medium Was a bit flaky. * Check flakiness * Revert presubmit tweak commit fa621c6 Author: jblebrun <jibbl@google.com> Date: Tue Mar 3 22:05:07 2020 -0800 Fix a race condition when setting up `ServiceStore` message channel (PolymerLabs#4826) This seems to be the cause of the flakiness in `AndroidAllocatorTest` and `AndroidHandleManagerTest` (PolymerLabs#4781) commit 78bf4f0 Author: Gogul Balakrishnan <bgogul@google.com> Date: Tue Mar 3 18:00:49 2020 -0800 Utility to convert type proto to field type (if possible). (PolymerLabs#4814) commit cae89c3 Merge: 0360752 e587539 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 15:50:34 2020 -0800 Merge branch 'master' of github.com:PolymerLabs/arcs into r2p commit e587539 Author: jblebrun <jibbl@google.com> Date: Tue Mar 3 15:07:16 2020 -0800 Apply simplified test pattern tests in `arcs.android.host` (PolymerLabs#4821) As in 5c6310d commit 1af1aac Author: Joshua Pratt <jp10010101010000@gmail.com> Date: Wed Mar 4 09:48:15 2020 +1100 Multinomials (PolymerLabs#4804) * multinomial * added tests * making constant readable again * reindent * added multivariate rearrangement tests * updated comment * pr comments: Co-authored-by: Ragav Sachdeva <ragavsachdeva007@gmail.com> commit 0360752 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 11:42:31 2020 -0800 fix, bad comparison op commit 4b05a28 Merge: f4c1d26 99000c2 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 11:18:14 2020 -0800 Merge branch 'r2p' of github.com:alxrsngrtn/arcs into r2p commit f4c1d26 Merge: 140111f 5c6310d Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 11:14:35 2020 -0800 Merge branch 'master' of github.com:PolymerLabs/arcs into r2p Fixed lint errors commit 99000c2 Merge: 140111f 5c6310d Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 11:14:35 2020 -0800 Merge branch 'master' of github.com:PolymerLabs/arcs into r2p Fixed lint errors commit 140111f Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 11:08:12 2020 -0800 Removed flatMap, added TODOs and link to GH issue commit 5c6310d Author: jblebrun <jibbl@google.com> Date: Tue Mar 3 11:02:34 2020 -0800 Simplify service test pattern (PolymerLabs#4817) * Make a simple test lifecycle registry, instead of creating empty testactivity * Remove use of `runBlockingTest`: according to Kotlin/kotlinx.coroutines#1222, if the test results in coroutines being finished on other threads, it's possible to receive "This job has not yet completed" exceptions, even though the jobs were properly terminated. Since we don't need the delay-skipping properties of `runBlockingTest`, I think it's OK to use `runBlocking`. commit 472bc84 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 10:27:56 2020 -0800 Improved build rules commit ca1ebf8 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 10:17:13 2020 -0800 Impl suggestsions for r2p commit b5578ea Author: Jason Feinstein <jwf@google.com> Date: Tue Mar 3 09:54:17 2020 -0800 Add tests for dereferencing references to the HandleManagerTest(s) (PolymerLabs#4816) * Add dereferencing tests to the android handle manager test. * Add dereferencing tests to core HandleManager. commit a695797 Author: Jason Feinstein <jwf@google.com> Date: Mon Mar 2 18:14:07 2020 -0800 Create RawEntityDereferencerTest, storage Reference-> CrdtEntity.Reference (PolymerLabs#4812) * Create RawEntityDereferencerTest, make storage Reference implement CrdtEntity.Reference. Also: Create ParcelableReference. * Add dep. Also, apparently read/writeBoolean is Q-only. * Just write null if there is no version map. * Just write null if there is no version map. commit ba7a107 Author: Gogul Balakrishnan <bgogul@google.com> Date: Mon Mar 2 17:51:35 2020 -0800 Add a decoder for PrimitiveTypeProto and an option to disable android constraints in BUILD. (PolymerLabs#4793) commit f6df54a Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 15:44:32 2020 -0800 tools/sigh lint commit bede8d9 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 14:52:02 2020 -0800 Fixed build rule, simplified runtime commit 62dcc57 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 14:38:14 2020 -0800 Fixed test, added TODO * fixed nested tests * rewording, reorganizing * assert more ergonomic commit 298fdcc Author: Maria Mandlis <mmandlis@chromium.org> Date: Wed Mar 4 15:29:37 2020 -0800 update wasm readme (PolymerLabs#4832) commit d15008e Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 15:11:14 2020 -0800 fixed build commit bbfc3d2 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 15:04:11 2020 -0800 EntitySpec Interface can return a schema commit 3b75c34 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 14:09:36 2020 -0800 ktlint fix commit 506457e Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 13:59:46 2020 -0800 addField arguments are more ergonomic commit 579b2e6 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 13:45:28 2020 -0800 grooming schema registry commit 3cb8023 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 11:39:30 2020 -0800 rm unused field commit 1cff99f Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 11:38:32 2020 -0800 rm import commit 855401c Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 11:31:14 2020 -0800 no difference w/ wasm golden commit 552e9ad Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 11:26:43 2020 -0800 Added test for mapOf commit 1430907 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 11:07:15 2020 -0800 sigh lint commit 9c22195 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 11:06:50 2020 -0800 minor adjustments commit 74ae770 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 10:58:20 2020 -0800 Improved shape of registry commit f69f99b Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 10:32:31 2020 -0800 excluding wasm from generation commit dcefb16 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 10:13:46 2020 -0800 Generation adds to schema registry commit f3b9ae5 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 07:57:15 2020 -0800 packaging in a schema registry commit 2ce6da2 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 22:30:39 2020 -0800 First iteration of schema gen on entities
alxmrs
added a commit
that referenced
this pull request
Mar 9, 2020
## Summary First iteration of generating Plan objects. ## Changelog * creating structure of ts r2p script * Created fast CLI rapper for r2p script * WIP figuring out ways to resolve a recipe * fix sp * Passing lint, still WIP * Build macros for recipe2plan work * Lightweight iteration on recipe2plan, stubbed out tests * Revised method to find corresponding create handles * Added type info * Added method to get all handles to manifest + get all handles by Id * fix: no flatMap * - currently, fails since it cannot find associated stores for handles. * uncleaned, but working recipe resolution * Cleaned up for r2p, pt 1 * Fixed test, added TODO * Fixed build rule, simplified runtime * tools/sigh lint * Impl suggestsions for r2p * Improved build rules * Removed flatMap, added TODOs and link to GH issue * fix, bad comparison op * Stub plan generator works * updated macro to take a package * Testing import is conditional on package * Incremental improvement * tidying * Fixed tests * added particle creation method * flushing out more of plan gen * Squashed commit of the following: commit 17a2ab1 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 16:30:45 2020 -0800 Fixed indentation commit 9094055 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 16:03:51 2020 -0800 revising from feedback commit d350821 Merge: 9054c23 3acb7e7 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 15:56:55 2020 -0800 Merge branch 'master' of github.com:PolymerLabs/arcs into s2k-schemas commit 3acb7e7 Author: Alex Rosengarten <alxr@google.com> Date: Wed Mar 4 15:56:42 2020 -0800 XXS CL to add a hash field to the Schema proto (#4752) commit 9054c23 Merge: d15008e 337b7b2 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 15:55:27 2020 -0800 Merge branch 'master' of github.com:PolymerLabs/arcs into s2k-schemas commit 337b7b2 Author: Alex Rosengarten <alxr@google.com> Date: Wed Mar 4 15:55:06 2020 -0800 recipe2plan 2/n: Validate Handles, Tests (#4834) * creating structure of ts r2p script * Created fast CLI rapper for r2p script * WIP figuring out ways to resolve a recipe * fix sp * Passing lint, still WIP * Build macros for recipe2plan work * Lightweight iteration on recipe2plan, stubbed out tests * Revised method to find corresponding create handles * Added type info * Added method to get all handles to manifest + get all handles by Id * fix: no flatMap * - currently, fails since it cannot find associated stores for handles. * uncleaned, but working recipe resolution * Cleaned up for r2p, pt 1 * stubbed out second test (short, short) * Squashed commit of the following: commit 62dcc57 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 14:38:14 2020 -0800 Fixed test, added TODO * updates to test, can't get two to fail * Squashed commit of the following: commit bede8d9 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 14:52:02 2020 -0800 Fixed build rule, simplified runtime commit 62dcc57 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 14:38:14 2020 -0800 Fixed test, added TODO * can't get test to fail... hmm... * Squashed commit of the following: commit f6df54a Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 15:44:32 2020 -0800 tools/sigh lint commit bede8d9 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 14:52:02 2020 -0800 Fixed build rule, simplified runtime commit 62dcc57 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 14:38:14 2020 -0800 Fixed test, added TODO * adjusting recipe copying to include triggers * Revert "adjusting recipe copying to include triggers" This reverts commit 9bc3734 * four tests complete * Added test, fixed minor async issue * Squashed commit of the following: commit 4b05a28 Merge: f4c1d26 99000c2 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 11:18:14 2020 -0800 Merge branch 'r2p' of github.com:alxrsngrtn/arcs into r2p commit f4c1d26 Merge: 140111f 5c6310d Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 11:14:35 2020 -0800 Merge branch 'master' of github.com:PolymerLabs/arcs into r2p Fixed lint errors commit 99000c2 Merge: 140111f 5c6310d Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 11:14:35 2020 -0800 Merge branch 'master' of github.com:PolymerLabs/arcs into r2p Fixed lint errors commit 140111f Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 11:08:12 2020 -0800 Removed flatMap, added TODOs and link to GH issue commit 5c6310d Author: jblebrun <jibbl@google.com> Date: Tue Mar 3 11:02:34 2020 -0800 Simplify service test pattern (#4817) * Make a simple test lifecycle registry, instead of creating empty testactivity * Remove use of `runBlockingTest`: according to Kotlin/kotlinx.coroutines#1222, if the test results in coroutines being finished on other threads, it's possible to receive "This job has not yet completed" exceptions, even though the jobs were properly terminated. Since we don't need the delay-skipping properties of `runBlockingTest`, I think it's OK to use `runBlocking`. commit 472bc84 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 10:27:56 2020 -0800 Improved build rules commit ca1ebf8 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 10:17:13 2020 -0800 Impl suggestsions for r2p commit b5578ea Author: Jason Feinstein <jwf@google.com> Date: Tue Mar 3 09:54:17 2020 -0800 Add tests for dereferencing references to the HandleManagerTest(s) (#4816) * Add dereferencing tests to the android handle manager test. * Add dereferencing tests to core HandleManager. commit a695797 Author: Jason Feinstein <jwf@google.com> Date: Mon Mar 2 18:14:07 2020 -0800 Create RawEntityDereferencerTest, storage Reference-> CrdtEntity.Reference (#4812) * Create RawEntityDereferencerTest, make storage Reference implement CrdtEntity.Reference. Also: Create ParcelableReference. * Add dep. Also, apparently read/writeBoolean is Q-only. * Just write null if there is no version map. * Just write null if there is no version map. commit ba7a107 Author: Gogul Balakrishnan <bgogul@google.com> Date: Mon Mar 2 17:51:35 2020 -0800 Add a decoder for PrimitiveTypeProto and an option to disable android constraints in BUILD. (#4793) commit f6df54a Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 15:44:32 2020 -0800 tools/sigh lint commit bede8d9 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 14:52:02 2020 -0800 Fixed build rule, simplified runtime commit 62dcc57 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 14:38:14 2020 -0800 Fixed test, added TODO * fix ineq * existing tests passing * Updating invalid type test * Squashed commit of the following: commit b3d92d0 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 12:17:17 2020 -0800 updated test name commit ba7884b Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 12:16:09 2020 -0800 nested unit tests commit ef36fdf Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 12:15:00 2020 -0800 renamed to tryResolve commit 5703f02 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 12:07:18 2020 -0800 rm generator commit 658cb1a Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 12:01:54 2020 -0800 implemented more review suggestions commit 0056ee3 Merge: cae89c3 0f0f82a Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 11:54:23 2020 -0800 Merge branch 'master' of github.com:PolymerLabs/arcs into r2p commit 0f0f82a Author: Maria Mandlis <mmandlis@chromium.org> Date: Wed Mar 4 09:33:29 2020 -0800 add queryable capability (#4794) commit d032c75 Author: Maria Mandlis <mmandlis@chromium.org> Date: Wed Mar 4 09:23:07 2020 -0800 add creatimeTimestamp to entities (kt) (#4823) commit 30267fc Author: jblebrun <jibbl@google.com> Date: Wed Mar 4 09:09:39 2020 -0800 Remove some unused deps (#4831) commit c519181 Author: Cameron Silvestrini <csilvestrini@users.noreply.github.com> Date: Wed Mar 4 17:14:07 2020 +1100 Increase size of DatabaseImplTest to medium (#4827) * Increase size of DatabaseImplTest to medium Was a bit flaky. * Check flakiness * Revert presubmit tweak commit fa621c6 Author: jblebrun <jibbl@google.com> Date: Tue Mar 3 22:05:07 2020 -0800 Fix a race condition when setting up `ServiceStore` message channel (#4826) This seems to be the cause of the flakiness in `AndroidAllocatorTest` and `AndroidHandleManagerTest` (#4781) commit 78bf4f0 Author: Gogul Balakrishnan <bgogul@google.com> Date: Tue Mar 3 18:00:49 2020 -0800 Utility to convert type proto to field type (if possible). (#4814) commit cae89c3 Merge: 0360752 e587539 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 15:50:34 2020 -0800 Merge branch 'master' of github.com:PolymerLabs/arcs into r2p commit e587539 Author: jblebrun <jibbl@google.com> Date: Tue Mar 3 15:07:16 2020 -0800 Apply simplified test pattern tests in `arcs.android.host` (#4821) As in 5c6310d commit 1af1aac Author: Joshua Pratt <jp10010101010000@gmail.com> Date: Wed Mar 4 09:48:15 2020 +1100 Multinomials (#4804) * multinomial * added tests * making constant readable again * reindent * added multivariate rearrangement tests * updated comment * pr comments: Co-authored-by: Ragav Sachdeva <ragavsachdeva007@gmail.com> commit 0360752 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 11:42:31 2020 -0800 fix, bad comparison op commit 4b05a28 Merge: f4c1d26 99000c2 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 11:18:14 2020 -0800 Merge branch 'r2p' of github.com:alxrsngrtn/arcs into r2p commit f4c1d26 Merge: 140111f 5c6310d Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 11:14:35 2020 -0800 Merge branch 'master' of github.com:PolymerLabs/arcs into r2p Fixed lint errors commit 99000c2 Merge: 140111f 5c6310d Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 11:14:35 2020 -0800 Merge branch 'master' of github.com:PolymerLabs/arcs into r2p Fixed lint errors commit 140111f Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 11:08:12 2020 -0800 Removed flatMap, added TODOs and link to GH issue commit 5c6310d Author: jblebrun <jibbl@google.com> Date: Tue Mar 3 11:02:34 2020 -0800 Simplify service test pattern (#4817) * Make a simple test lifecycle registry, instead of creating empty testactivity * Remove use of `runBlockingTest`: according to Kotlin/kotlinx.coroutines#1222, if the test results in coroutines being finished on other threads, it's possible to receive "This job has not yet completed" exceptions, even though the jobs were properly terminated. Since we don't need the delay-skipping properties of `runBlockingTest`, I think it's OK to use `runBlocking`. commit 472bc84 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 10:27:56 2020 -0800 Improved build rules commit ca1ebf8 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 10:17:13 2020 -0800 Impl suggestsions for r2p commit b5578ea Author: Jason Feinstein <jwf@google.com> Date: Tue Mar 3 09:54:17 2020 -0800 Add tests for dereferencing references to the HandleManagerTest(s) (#4816) * Add dereferencing tests to the android handle manager test. * Add dereferencing tests to core HandleManager. commit a695797 Author: Jason Feinstein <jwf@google.com> Date: Mon Mar 2 18:14:07 2020 -0800 Create RawEntityDereferencerTest, storage Reference-> CrdtEntity.Reference (#4812) * Create RawEntityDereferencerTest, make storage Reference implement CrdtEntity.Reference. Also: Create ParcelableReference. * Add dep. Also, apparently read/writeBoolean is Q-only. * Just write null if there is no version map. * Just write null if there is no version map. commit ba7a107 Author: Gogul Balakrishnan <bgogul@google.com> Date: Mon Mar 2 17:51:35 2020 -0800 Add a decoder for PrimitiveTypeProto and an option to disable android constraints in BUILD. (#4793) commit f6df54a Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 15:44:32 2020 -0800 tools/sigh lint commit bede8d9 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 14:52:02 2020 -0800 Fixed build rule, simplified runtime commit 62dcc57 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 14:38:14 2020 -0800 Fixed test, added TODO * fixed nested tests * rewording, reorganizing * assert more ergonomic commit 298fdcc Author: Maria Mandlis <mmandlis@chromium.org> Date: Wed Mar 4 15:29:37 2020 -0800 update wasm readme (#4832) commit d15008e Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 15:11:14 2020 -0800 fixed build commit bbfc3d2 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 15:04:11 2020 -0800 EntitySpec Interface can return a schema commit 3b75c34 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 14:09:36 2020 -0800 ktlint fix commit 506457e Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 13:59:46 2020 -0800 addField arguments are more ergonomic commit 579b2e6 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 13:45:28 2020 -0800 grooming schema registry commit 3cb8023 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 11:39:30 2020 -0800 rm unused field commit 1cff99f Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 11:38:32 2020 -0800 rm import commit 855401c Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 11:31:14 2020 -0800 no difference w/ wasm golden commit 552e9ad Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 11:26:43 2020 -0800 Added test for mapOf commit 1430907 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 11:07:15 2020 -0800 sigh lint commit 9c22195 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 11:06:50 2020 -0800 minor adjustments commit 74ae770 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 10:58:20 2020 -0800 Improved shape of registry commit f69f99b Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 10:32:31 2020 -0800 excluding wasm from generation commit dcefb16 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 10:13:46 2020 -0800 Generation adds to schema registry commit f3b9ae5 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 07:57:15 2020 -0800 packaging in a schema registry commit 2ce6da2 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 22:30:39 2020 -0800 First iteration of schema gen on entities * Squashed commit of the following: commit b26f13e Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Thu Mar 5 17:14:33 2020 -0800 updated goldens commit f66fdd8 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Thu Mar 5 16:56:26 2020 -0800 further cleanup commit 46b4f17 Merge: cfcf317 8621c58 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Thu Mar 5 16:54:11 2020 -0800 Merge branch 'master' of github.com:PolymerLabs/arcs into kt-gen-utils commit cfcf317 Merge: 60582ed 623daf7 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Thu Mar 5 16:28:56 2020 -0800 Merge branch 'master' of github.com:PolymerLabs/arcs into kt-gen-utils commit 60582ed Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Thu Mar 5 15:27:30 2020 -0800 lint fix, added a test commit 196a4a9 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Thu Mar 5 15:16:35 2020 -0800 cleaned up ktUtils, passing tests commit 142fa2b Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 17:42:04 2020 -0800 first iteration for kt utils commit e55cb0b Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 17:36:00 2020 -0800 Squashed commit of the following: commit 17a2ab1 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 16:30:45 2020 -0800 Fixed indentation commit 9094055 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 16:03:51 2020 -0800 revising from feedback commit d350821 Merge: 9054c23 3acb7e7 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 15:56:55 2020 -0800 Merge branch 'master' of github.com:PolymerLabs/arcs into s2k-schemas commit 9054c23 Merge: d15008e 337b7b2 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 15:55:27 2020 -0800 Merge branch 'master' of github.com:PolymerLabs/arcs into s2k-schemas commit d15008e Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 15:11:14 2020 -0800 fixed build commit bbfc3d2 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 15:04:11 2020 -0800 EntitySpec Interface can return a schema commit 3b75c34 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 14:09:36 2020 -0800 ktlint fix commit 506457e Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 13:59:46 2020 -0800 addField arguments are more ergonomic commit 579b2e6 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 13:45:28 2020 -0800 grooming schema registry commit 3cb8023 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 11:39:30 2020 -0800 rm unused field commit 1cff99f Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 11:38:32 2020 -0800 rm import commit 855401c Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 11:31:14 2020 -0800 no difference w/ wasm golden commit 552e9ad Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 11:26:43 2020 -0800 Added test for mapOf commit 1430907 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 11:07:15 2020 -0800 sigh lint commit 9c22195 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 11:06:50 2020 -0800 minor adjustments commit 74ae770 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 10:58:20 2020 -0800 Improved shape of registry commit f69f99b Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 10:32:31 2020 -0800 excluding wasm from generation commit dcefb16 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 10:13:46 2020 -0800 Generation adds to schema registry commit f3b9ae5 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 07:57:15 2020 -0800 packaging in a schema registry commit 2ce6da2 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 22:30:39 2020 -0800 First iteration of schema gen on entities * using kt gen utils * fixed merge issue * Added new kt util * creating handle connections * handle connection map, lots of progress * incomplete, but valid plan generator * Groomed plan gen * fix jvm golden * 1 missing semicolon * buildifier fix * Code quality improvements. * Code quality improvements. * Added golden in testdata, revealed codegen issue from refactoring! * Added golden test for r2p * mv tests to goldens dir * updating whitespace * name change * rm default package * guard imports Co-authored-by: Alex Rosengarten <alxrsngrtn@google.com>
alxmrs
added a commit
that referenced
this pull request
Mar 10, 2020
## Summary Enhances #4865, generates Types within Kotlin Plan classes. For an example, see Golden's modification. ## Changelog * creating structure of ts r2p script * Created fast CLI rapper for r2p script * WIP figuring out ways to resolve a recipe * fix sp * Passing lint, still WIP * Build macros for recipe2plan work * Lightweight iteration on recipe2plan, stubbed out tests * Revised method to find corresponding create handles * Added type info * Added method to get all handles to manifest + get all handles by Id * fix: no flatMap * - currently, fails since it cannot find associated stores for handles. * uncleaned, but working recipe resolution * Cleaned up for r2p, pt 1 * Fixed test, added TODO * Fixed build rule, simplified runtime * tools/sigh lint * Impl suggestsions for r2p * Improved build rules * Removed flatMap, added TODOs and link to GH issue * fix, bad comparison op * Stub plan generator works * updated macro to take a package * Testing import is conditional on package * Incremental improvement * tidying * Fixed tests * added particle creation method * flushing out more of plan gen * Squashed commit of the following: commit 17a2ab1 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 16:30:45 2020 -0800 Fixed indentation commit 9094055 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 16:03:51 2020 -0800 revising from feedback commit d350821 Merge: 9054c23 3acb7e7 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 15:56:55 2020 -0800 Merge branch 'master' of github.com:PolymerLabs/arcs into s2k-schemas commit 3acb7e7 Author: Alex Rosengarten <alxr@google.com> Date: Wed Mar 4 15:56:42 2020 -0800 XXS CL to add a hash field to the Schema proto (#4752) commit 9054c23 Merge: d15008e 337b7b2 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 15:55:27 2020 -0800 Merge branch 'master' of github.com:PolymerLabs/arcs into s2k-schemas commit 337b7b2 Author: Alex Rosengarten <alxr@google.com> Date: Wed Mar 4 15:55:06 2020 -0800 recipe2plan 2/n: Validate Handles, Tests (#4834) * creating structure of ts r2p script * Created fast CLI rapper for r2p script * WIP figuring out ways to resolve a recipe * fix sp * Passing lint, still WIP * Build macros for recipe2plan work * Lightweight iteration on recipe2plan, stubbed out tests * Revised method to find corresponding create handles * Added type info * Added method to get all handles to manifest + get all handles by Id * fix: no flatMap * - currently, fails since it cannot find associated stores for handles. * uncleaned, but working recipe resolution * Cleaned up for r2p, pt 1 * stubbed out second test (short, short) * Squashed commit of the following: commit 62dcc57 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 14:38:14 2020 -0800 Fixed test, added TODO * updates to test, can't get two to fail * Squashed commit of the following: commit bede8d9 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 14:52:02 2020 -0800 Fixed build rule, simplified runtime commit 62dcc57 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 14:38:14 2020 -0800 Fixed test, added TODO * can't get test to fail... hmm... * Squashed commit of the following: commit f6df54a Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 15:44:32 2020 -0800 tools/sigh lint commit bede8d9 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 14:52:02 2020 -0800 Fixed build rule, simplified runtime commit 62dcc57 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 14:38:14 2020 -0800 Fixed test, added TODO * adjusting recipe copying to include triggers * Revert "adjusting recipe copying to include triggers" This reverts commit 9bc3734 * four tests complete * Added test, fixed minor async issue * Squashed commit of the following: commit 4b05a28 Merge: f4c1d26 99000c2 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 11:18:14 2020 -0800 Merge branch 'r2p' of github.com:alxrsngrtn/arcs into r2p commit f4c1d26 Merge: 140111f 5c6310d Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 11:14:35 2020 -0800 Merge branch 'master' of github.com:PolymerLabs/arcs into r2p Fixed lint errors commit 99000c2 Merge: 140111f 5c6310d Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 11:14:35 2020 -0800 Merge branch 'master' of github.com:PolymerLabs/arcs into r2p Fixed lint errors commit 140111f Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 11:08:12 2020 -0800 Removed flatMap, added TODOs and link to GH issue commit 5c6310d Author: jblebrun <jibbl@google.com> Date: Tue Mar 3 11:02:34 2020 -0800 Simplify service test pattern (#4817) * Make a simple test lifecycle registry, instead of creating empty testactivity * Remove use of `runBlockingTest`: according to Kotlin/kotlinx.coroutines#1222, if the test results in coroutines being finished on other threads, it's possible to receive "This job has not yet completed" exceptions, even though the jobs were properly terminated. Since we don't need the delay-skipping properties of `runBlockingTest`, I think it's OK to use `runBlocking`. commit 472bc84 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 10:27:56 2020 -0800 Improved build rules commit ca1ebf8 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 10:17:13 2020 -0800 Impl suggestsions for r2p commit b5578ea Author: Jason Feinstein <jwf@google.com> Date: Tue Mar 3 09:54:17 2020 -0800 Add tests for dereferencing references to the HandleManagerTest(s) (#4816) * Add dereferencing tests to the android handle manager test. * Add dereferencing tests to core HandleManager. commit a695797 Author: Jason Feinstein <jwf@google.com> Date: Mon Mar 2 18:14:07 2020 -0800 Create RawEntityDereferencerTest, storage Reference-> CrdtEntity.Reference (#4812) * Create RawEntityDereferencerTest, make storage Reference implement CrdtEntity.Reference. Also: Create ParcelableReference. * Add dep. Also, apparently read/writeBoolean is Q-only. * Just write null if there is no version map. * Just write null if there is no version map. commit ba7a107 Author: Gogul Balakrishnan <bgogul@google.com> Date: Mon Mar 2 17:51:35 2020 -0800 Add a decoder for PrimitiveTypeProto and an option to disable android constraints in BUILD. (#4793) commit f6df54a Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 15:44:32 2020 -0800 tools/sigh lint commit bede8d9 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 14:52:02 2020 -0800 Fixed build rule, simplified runtime commit 62dcc57 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 14:38:14 2020 -0800 Fixed test, added TODO * fix ineq * existing tests passing * Updating invalid type test * Squashed commit of the following: commit b3d92d0 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 12:17:17 2020 -0800 updated test name commit ba7884b Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 12:16:09 2020 -0800 nested unit tests commit ef36fdf Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 12:15:00 2020 -0800 renamed to tryResolve commit 5703f02 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 12:07:18 2020 -0800 rm generator commit 658cb1a Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 12:01:54 2020 -0800 implemented more review suggestions commit 0056ee3 Merge: cae89c3 0f0f82a Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 11:54:23 2020 -0800 Merge branch 'master' of github.com:PolymerLabs/arcs into r2p commit 0f0f82a Author: Maria Mandlis <mmandlis@chromium.org> Date: Wed Mar 4 09:33:29 2020 -0800 add queryable capability (#4794) commit d032c75 Author: Maria Mandlis <mmandlis@chromium.org> Date: Wed Mar 4 09:23:07 2020 -0800 add creatimeTimestamp to entities (kt) (#4823) commit 30267fc Author: jblebrun <jibbl@google.com> Date: Wed Mar 4 09:09:39 2020 -0800 Remove some unused deps (#4831) commit c519181 Author: Cameron Silvestrini <csilvestrini@users.noreply.github.com> Date: Wed Mar 4 17:14:07 2020 +1100 Increase size of DatabaseImplTest to medium (#4827) * Increase size of DatabaseImplTest to medium Was a bit flaky. * Check flakiness * Revert presubmit tweak commit fa621c6 Author: jblebrun <jibbl@google.com> Date: Tue Mar 3 22:05:07 2020 -0800 Fix a race condition when setting up `ServiceStore` message channel (#4826) This seems to be the cause of the flakiness in `AndroidAllocatorTest` and `AndroidHandleManagerTest` (#4781) commit 78bf4f0 Author: Gogul Balakrishnan <bgogul@google.com> Date: Tue Mar 3 18:00:49 2020 -0800 Utility to convert type proto to field type (if possible). (#4814) commit cae89c3 Merge: 0360752 e587539 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 15:50:34 2020 -0800 Merge branch 'master' of github.com:PolymerLabs/arcs into r2p commit e587539 Author: jblebrun <jibbl@google.com> Date: Tue Mar 3 15:07:16 2020 -0800 Apply simplified test pattern tests in `arcs.android.host` (#4821) As in 5c6310d commit 1af1aac Author: Joshua Pratt <jp10010101010000@gmail.com> Date: Wed Mar 4 09:48:15 2020 +1100 Multinomials (#4804) * multinomial * added tests * making constant readable again * reindent * added multivariate rearrangement tests * updated comment * pr comments: Co-authored-by: Ragav Sachdeva <ragavsachdeva007@gmail.com> commit 0360752 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 11:42:31 2020 -0800 fix, bad comparison op commit 4b05a28 Merge: f4c1d26 99000c2 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 11:18:14 2020 -0800 Merge branch 'r2p' of github.com:alxrsngrtn/arcs into r2p commit f4c1d26 Merge: 140111f 5c6310d Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 11:14:35 2020 -0800 Merge branch 'master' of github.com:PolymerLabs/arcs into r2p Fixed lint errors commit 99000c2 Merge: 140111f 5c6310d Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 11:14:35 2020 -0800 Merge branch 'master' of github.com:PolymerLabs/arcs into r2p Fixed lint errors commit 140111f Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 11:08:12 2020 -0800 Removed flatMap, added TODOs and link to GH issue commit 5c6310d Author: jblebrun <jibbl@google.com> Date: Tue Mar 3 11:02:34 2020 -0800 Simplify service test pattern (#4817) * Make a simple test lifecycle registry, instead of creating empty testactivity * Remove use of `runBlockingTest`: according to Kotlin/kotlinx.coroutines#1222, if the test results in coroutines being finished on other threads, it's possible to receive "This job has not yet completed" exceptions, even though the jobs were properly terminated. Since we don't need the delay-skipping properties of `runBlockingTest`, I think it's OK to use `runBlocking`. commit 472bc84 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 10:27:56 2020 -0800 Improved build rules commit ca1ebf8 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 10:17:13 2020 -0800 Impl suggestsions for r2p commit b5578ea Author: Jason Feinstein <jwf@google.com> Date: Tue Mar 3 09:54:17 2020 -0800 Add tests for dereferencing references to the HandleManagerTest(s) (#4816) * Add dereferencing tests to the android handle manager test. * Add dereferencing tests to core HandleManager. commit a695797 Author: Jason Feinstein <jwf@google.com> Date: Mon Mar 2 18:14:07 2020 -0800 Create RawEntityDereferencerTest, storage Reference-> CrdtEntity.Reference (#4812) * Create RawEntityDereferencerTest, make storage Reference implement CrdtEntity.Reference. Also: Create ParcelableReference. * Add dep. Also, apparently read/writeBoolean is Q-only. * Just write null if there is no version map. * Just write null if there is no version map. commit ba7a107 Author: Gogul Balakrishnan <bgogul@google.com> Date: Mon Mar 2 17:51:35 2020 -0800 Add a decoder for PrimitiveTypeProto and an option to disable android constraints in BUILD. (#4793) commit f6df54a Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 15:44:32 2020 -0800 tools/sigh lint commit bede8d9 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 14:52:02 2020 -0800 Fixed build rule, simplified runtime commit 62dcc57 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Mon Mar 2 14:38:14 2020 -0800 Fixed test, added TODO * fixed nested tests * rewording, reorganizing * assert more ergonomic commit 298fdcc Author: Maria Mandlis <mmandlis@chromium.org> Date: Wed Mar 4 15:29:37 2020 -0800 update wasm readme (#4832) commit d15008e Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 15:11:14 2020 -0800 fixed build commit bbfc3d2 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 15:04:11 2020 -0800 EntitySpec Interface can return a schema commit 3b75c34 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 14:09:36 2020 -0800 ktlint fix commit 506457e Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 13:59:46 2020 -0800 addField arguments are more ergonomic commit 579b2e6 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 13:45:28 2020 -0800 grooming schema registry commit 3cb8023 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 11:39:30 2020 -0800 rm unused field commit 1cff99f Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 11:38:32 2020 -0800 rm import commit 855401c Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 11:31:14 2020 -0800 no difference w/ wasm golden commit 552e9ad Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 11:26:43 2020 -0800 Added test for mapOf commit 1430907 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 11:07:15 2020 -0800 sigh lint commit 9c22195 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 11:06:50 2020 -0800 minor adjustments commit 74ae770 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 10:58:20 2020 -0800 Improved shape of registry commit f69f99b Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 10:32:31 2020 -0800 excluding wasm from generation commit dcefb16 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 10:13:46 2020 -0800 Generation adds to schema registry commit f3b9ae5 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 07:57:15 2020 -0800 packaging in a schema registry commit 2ce6da2 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 22:30:39 2020 -0800 First iteration of schema gen on entities * Squashed commit of the following: commit b26f13e Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Thu Mar 5 17:14:33 2020 -0800 updated goldens commit f66fdd8 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Thu Mar 5 16:56:26 2020 -0800 further cleanup commit 46b4f17 Merge: cfcf317 8621c58 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Thu Mar 5 16:54:11 2020 -0800 Merge branch 'master' of github.com:PolymerLabs/arcs into kt-gen-utils commit cfcf317 Merge: 60582ed 623daf7 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Thu Mar 5 16:28:56 2020 -0800 Merge branch 'master' of github.com:PolymerLabs/arcs into kt-gen-utils commit 60582ed Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Thu Mar 5 15:27:30 2020 -0800 lint fix, added a test commit 196a4a9 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Thu Mar 5 15:16:35 2020 -0800 cleaned up ktUtils, passing tests commit 142fa2b Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 17:42:04 2020 -0800 first iteration for kt utils commit e55cb0b Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 17:36:00 2020 -0800 Squashed commit of the following: commit 17a2ab1 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 16:30:45 2020 -0800 Fixed indentation commit 9094055 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 16:03:51 2020 -0800 revising from feedback commit d350821 Merge: 9054c23 3acb7e7 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 15:56:55 2020 -0800 Merge branch 'master' of github.com:PolymerLabs/arcs into s2k-schemas commit 9054c23 Merge: d15008e 337b7b2 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 15:55:27 2020 -0800 Merge branch 'master' of github.com:PolymerLabs/arcs into s2k-schemas commit d15008e Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 15:11:14 2020 -0800 fixed build commit bbfc3d2 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 15:04:11 2020 -0800 EntitySpec Interface can return a schema commit 3b75c34 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 14:09:36 2020 -0800 ktlint fix commit 506457e Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 13:59:46 2020 -0800 addField arguments are more ergonomic commit 579b2e6 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 13:45:28 2020 -0800 grooming schema registry commit 3cb8023 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 11:39:30 2020 -0800 rm unused field commit 1cff99f Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 11:38:32 2020 -0800 rm import commit 855401c Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 11:31:14 2020 -0800 no difference w/ wasm golden commit 552e9ad Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 11:26:43 2020 -0800 Added test for mapOf commit 1430907 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 11:07:15 2020 -0800 sigh lint commit 9c22195 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 11:06:50 2020 -0800 minor adjustments commit 74ae770 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 10:58:20 2020 -0800 Improved shape of registry commit f69f99b Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 10:32:31 2020 -0800 excluding wasm from generation commit dcefb16 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 10:13:46 2020 -0800 Generation adds to schema registry commit f3b9ae5 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Wed Mar 4 07:57:15 2020 -0800 packaging in a schema registry commit 2ce6da2 Author: Alex Rosengarten <alxrsngrtn@google.com> Date: Tue Mar 3 22:30:39 2020 -0800 First iteration of schema gen on entities * using kt gen utils * fixed merge issue * Added new kt util * creating handle connections * handle connection map, lots of progress * incomplete, but valid plan generator * Groomed plan gen * fix jvm golden * 1 missing semicolon * Impl createType w/ tests * buildifier fix * Code quality improvements. * Code quality improvements. * Added golden in testdata, revealed codegen issue from refactoring! * Added golden test for r2p * mv tests to goldens dir * updating whitespace * name change * rm default package * guard imports * fixes: now passing tests after merge * fix: need to wrap a list * extracted generic function to kt utils * using schemas on specs * using schemas on specs * Fixed tests * clean up * impl suggestions from feedback * fixed lint / functionality issue * schema --> SCHEMA * rm unused imports * Fixed the reference key issue; added Flags function * better plance for `Flags` call Co-authored-by: Alex Rosengarten <alxrsngrtn@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.