Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The prepublish script is not cross-platform compatible #312

Open
Pomax opened this issue Feb 20, 2019 · 1 comment
Open

The prepublish script is not cross-platform compatible #312

Pomax opened this issue Feb 20, 2019 · 1 comment

Comments

@Pomax
Copy link
Owner

Pomax commented Feb 20, 2019

The prepublish script is currently of a form that cannot ever work on a windows machine: test $(npm -v | tr . '\\n' | head -n 1) -ge '4' || exit 1 uses shell-specific syntax. If there is no cross-platform way to run this as a set of shell instructions, then there might be node projects to help turn this into something cross-platform compatible (e.g. shx and the like), or barring that, be turned into a prepublish.js that can be invoked using "prepublish": "node test/prepublish.js".

/cc @Andarist

@Andarist
Copy link
Collaborator

Yeah, this would have to be rewritten to plain JS to achieve cross-platform compatibility in the easiest way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants