Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Br/travis #9

Merged
merged 42 commits into from
Jun 26, 2019
Merged

Br/travis #9

merged 42 commits into from
Jun 26, 2019

Conversation

breitman
Copy link
Collaborator

No description provided.

@hallettj
Copy link
Contributor

hallettj commented Jun 25, 2019

According to what I have read the no version information available warning happens because we are running a pre-built binary (probably electron) that is compiled against a newer version of a shared library than what is installed on Travis. Those messages might go away if we configure Travis to use a newer Ubuntu version. The latest version that Travis supports is Ubuntu Xenial (16.04) (see here). There are instructions for setting the build dist here.

Edit: using Ubuntu 16.04 might also fix the extension "RANDR" missing message according to this post.

.travis.yml Outdated

# before_script:
# - "export DISPLAY=:99.0"
# - "sh -e /etc/init.d/xvfb start"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like tests are running, and this before_script block is not necessary.

scripts/tests Outdated
set -e

(cd packages/main && eslint src/**/*.ts)
(cd packages/client && eslint src/**/*.ts)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It turns out that the eslint command I gave you misses problems in .tsx files. You can use these commands instead:

(cd packages/main && eslint src/**/*.ts src/**/*.tsx)
(cd packages/client && eslint src/**/*.ts src/**/*.tsx)

@hallettj
Copy link
Contributor

In a previous iteration of poodle I used this Travis configuration to cache package builds:

env:
  global:
    - ELECTRON_CACHE=$HOME/.cache/electron
    - ELECTRON_BUILDER_CACHE=$HOME/.cache/electron-builder

cache:
  yarn: true
  directories:
    - $HOME/.cache/electron
    - $HOME/.cache/electron-builder
    - $HOME/.electron
    - $HOME/.electron-gyp
    - $HOME/.node-gyp
    - $HOME/.npm/_prebuilds

We can run tests in a MacOS environment in addition to a Linux environment with this config:

os:
  - linux
  - osx

That might be helpful to prevent me from accidentally breaking your development environment. If you make that change you will need to change the way that apt packages are installed so that the apt-get install step only runs in the Linux environment. You can do that by replacing the before_install block with an invocation of the apt addon like this:

addons:
  apt:
    packages:
      - libgnome-keyring-dev
      - libsecret-1-dev
      - xvfb

@breitman breitman merged commit f6d97e5 into master Jun 26, 2019
@breitman breitman deleted the BR/Travis branch June 26, 2019 20:21
@hallettj
Copy link
Contributor

hallettj commented Nov 3, 2019

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@hallettj
Copy link
Contributor

hallettj commented Nov 4, 2019

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants