-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Br/travis #9
Conversation
According to what I have read the Edit: using Ubuntu 16.04 might also fix the |
.travis.yml
Outdated
|
||
# before_script: | ||
# - "export DISPLAY=:99.0" | ||
# - "sh -e /etc/init.d/xvfb start" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like tests are running, and this before_script
block is not necessary.
scripts/tests
Outdated
set -e | ||
|
||
(cd packages/main && eslint src/**/*.ts) | ||
(cd packages/client && eslint src/**/*.ts) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It turns out that the eslint command I gave you misses problems in .tsx
files. You can use these commands instead:
(cd packages/main && eslint src/**/*.ts src/**/*.tsx)
(cd packages/client && eslint src/**/*.ts src/**/*.tsx)
In a previous iteration of poodle I used this Travis configuration to cache package builds: env:
global:
- ELECTRON_CACHE=$HOME/.cache/electron
- ELECTRON_BUILDER_CACHE=$HOME/.cache/electron-builder
cache:
yarn: true
directories:
- $HOME/.cache/electron
- $HOME/.cache/electron-builder
- $HOME/.electron
- $HOME/.electron-gyp
- $HOME/.node-gyp
- $HOME/.npm/_prebuilds We can run tests in a MacOS environment in addition to a Linux environment with this config: os:
- linux
- osx That might be helpful to prevent me from accidentally breaking your development environment. If you make that change you will need to change the way that apt packages are installed so that the addons:
apt:
packages:
- libgnome-keyring-dev
- libsecret-1-dev
- xvfb |
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.