Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSVC build file: remove /Gm option #730

Closed
RossBencina opened this issue Sep 6, 2022 · 0 comments · Fixed by #756
Closed

MSVC build file: remove /Gm option #730

RossBencina opened this issue Sep 6, 2022 · 0 comments · Fixed by #756
Assignees
Labels
build-msvs MSVS project file builds P2 Priority: High

Comments

@RossBencina
Copy link
Collaborator

RossBencina commented Sep 6, 2022

On 5/9/2022 Karin Johnson reported on the mailing list (in an attached .doc) that the PA MSVC build was generating a deprecation warning when building for Win32 in Debug mode.

/Gm (Enable Minimal Rebuild) is deprecated. It generates the following warning with recent MSVC

option 'Gm' has been deprecated and will be removed in a future release

https://docs.microsoft.com/en-us/cpp/build/reference/gm-enable-minimal-rebuild?view=msvc-170

Best we remove it I think. It might speed up rebuilds in some cases but, aside from it being deprecated, we should favor correct builds over speedy rebuilds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-msvs MSVS project file builds P2 Priority: High
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant