Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Less dancing in dashboards #3824

Merged
merged 2 commits into from
Apr 9, 2021
Merged

Less dancing in dashboards #3824

merged 2 commits into from
Apr 9, 2021

Conversation

paolodamico
Copy link
Contributor

@paolodamico paolodamico commented Mar 30, 2021 •
edited
Loading

Changes

  • Closes Too much dancing (Feedback) #3671.
  • The dashboard wobbling is now only shown when the user is on a mobile device (see motivation on related issue).
  • Reduces the noise in the wobbly effect in the dashboard edit mode.
    image

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@paolodamico paolodamico mentioned this pull request Mar 30, 2021
Closed
@timgl timgl temporarily deployed to posthog-pr-3824 March 30, 2021 23:58 Inactive
@paolodamico paolodamico marked this pull request as ready for review April 8, 2021 23:25
@paolodamico paolodamico requested a review from EDsCODE April 8, 2021 23:27
@paolodamico paolodamico merged commit 2143e5f into master Apr 9, 2021
@paolodamico paolodamico deleted the less-dancing branch April 9, 2021 19:03
fuziontech pushed a commit that referenced this pull request Apr 19, 2021
@EDsCODE
Merge branch '3765-cohort-by-trend' of github.com:PostHog/posthog int…
b984c38 
…o 3765-cohort-by-trend

* '3765-cohort-by-trend' of github.com:PostHog/posthog: (39 commits)
  'string, parsable as datetime' (#3942)
  Update plugin server to 0.16.3 (#3944)
  Resizable table columns in Sessions (#3927)
  bump cryptography==3.4.7 and add macosx_arm64 install script (#3935)
  🤖: Add jeduden as a contributor 🎉 (#3938)
  Fix feature flags default rollout (#3745)
  Less dancing in dashboards (#3824)
  Always show event stats and add warnings (#3908)
  Update plugin server to 0.16.2 (#3932)
  Minimum PostHog version in plugins (#3916)
  Renames Active users to Unique users (#3930)
  Fix action with same name (#3909)
  Fix navigation to insights from dashboards (#3928)
  User V2 Part II - Frontend changes (#3866)
  update autocapture label to be more descriptive (#3925)
  Log to sentry when migrations are out of date (#3924)
  Revert "Increase Element model varchar limits (#3912)" (#3923)
  Update plugin server to 0.16.1 (#3920)
  Are migrations safe to run on cloud?  (#3917)
  Run Automerge as posthog-bot (#3919)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EDsCODE EDsCODE EDsCODE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Too much dancing (Feedback)
3 participants
@paolodamico @EDsCODE @timgl