Minimum PostHog version in plugins #3916
Conversation
|
👍 for the changes! What happened with the tests though? |
This reverts commit b720e1e.
There was a problem hiding this comment.
Ah, sorry for the mess, here's a comment most of which I wanted to post earlier but forgot 😅
Good solution. 👍
I split the single test of this into multiple ones for granularity.
Also disabled this check on Cloud as Cloud's always on the edge. Does this looks right to you?
As for Cloud CI job, it was red because the new package wasn't installed when it'd normally be due to the way the job was set up (as it also ensures that the PR will result in a safe migration in prod). I also had to fiddle with pip install caching there, as it was causing weird behavior. Ended up removing actions/cache in that job for now, it's only a difference of ~30 seconds.
BTW it's interesting that there are practically two competing PyPI packages for semver, previously I looked at https://pypi.org/project/semver/ for this. Wonder what's the difference.
|
Cool! All changes do make sense to me, so merging. Regarding the two projects (semver vs the one used here), I think semver didn't have a good support for version ranges/specifications. Thus I decided to use the other one. |
…o 3765-cohort-by-trend * '3765-cohort-by-trend' of github.com:PostHog/posthog: (39 commits) 'string, parsable as datetime' (#3942) Update plugin server to 0.16.3 (#3944) Resizable table columns in Sessions (#3927) bump cryptography==3.4.7 and add macosx_arm64 install script (#3935) 🤖: Add jeduden as a contributor 🎉 (#3938) Fix feature flags default rollout (#3745) Less dancing in dashboards (#3824) Always show event stats and add warnings (#3908) Update plugin server to 0.16.2 (#3932) Minimum PostHog version in plugins (#3916) Renames Active users to Unique users (#3930) Fix action with same name (#3909) Fix navigation to insights from dashboards (#3928) User V2 Part II - Frontend changes (#3866) update autocapture label to be more descriptive (#3925) Log to sentry when migrations are out of date (#3924) Revert "Increase Element model varchar limits (#3912)" (#3923) Update plugin server to 0.16.1 (#3920) Are migrations safe to run on cloud? (#3917) Run Automerge as posthog-bot (#3919) ...
Changes
posthogVersionfield is present inplugin.json, we will use it to compare if we are running a compatible version.Checklist