Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Are migrations safe to run on cloud? #3917

Merged
merged 2 commits into from
Apr 8, 2021
Merged

Are migrations safe to run on cloud? #3917

merged 2 commits into from
Apr 8, 2021

Conversation

mariusandra
Copy link
Collaborator

Changes

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@mariusandra mariusandra requested a review from Twixes April 8, 2021 16:58
@timgl timgl temporarily deployed to posthog-pr-3917 April 8, 2021 17:03 Inactive
@Twixes Twixes temporarily deployed to posthog-pr-3917 April 8, 2021 18:19 Inactive
Twixes
Twixes approved these changes Apr 8, 2021
View reviewed changes
Copy link
Collaborator

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, reworded slightly to also have other large deployments in mind that aren't Cloud

@Twixes Twixes added the automerge Merge this PR automatically when REQUIRED checks pass label Apr 8, 2021
@github-actions github-actions bot merged commit f1517ba into master Apr 8, 2021
@github-actions github-actions bot deleted the pr-migration-proof branch April 8, 2021 18:32
fuziontech pushed a commit that referenced this pull request Apr 19, 2021
@EDsCODE
Merge branch '3765-cohort-by-trend' of github.com:PostHog/posthog int…
b984c38 
…o 3765-cohort-by-trend

* '3765-cohort-by-trend' of github.com:PostHog/posthog: (39 commits)
  'string, parsable as datetime' (#3942)
  Update plugin server to 0.16.3 (#3944)
  Resizable table columns in Sessions (#3927)
  bump cryptography==3.4.7 and add macosx_arm64 install script (#3935)
  🤖: Add jeduden as a contributor 🎉 (#3938)
  Fix feature flags default rollout (#3745)
  Less dancing in dashboards (#3824)
  Always show event stats and add warnings (#3908)
  Update plugin server to 0.16.2 (#3932)
  Minimum PostHog version in plugins (#3916)
  Renames Active users to Unique users (#3930)
  Fix action with same name (#3909)
  Fix navigation to insights from dashboards (#3928)
  User V2 Part II - Frontend changes (#3866)
  update autocapture label to be more descriptive (#3925)
  Log to sentry when migrations are out of date (#3924)
  Revert "Increase Element model varchar limits (#3912)" (#3923)
  Update plugin server to 0.16.1 (#3920)
  Are migrations safe to run on cloud?  (#3917)
  Run Automerge as posthog-bot (#3919)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Twixes Twixes Twixes approved these changes

Assignees
No one assigned
Labels
automerge Merge this PR automatically when REQUIRED checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mariusandra @Twixes @timgl