Fix "Rendered more hooks than during the previous render." in LineGraph #8316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, looks like there are two crashes possible:
|
|
I believe problem 2. is a race condition between when the chart is generated and when it's sized, but not sure where exactly does this occur. However, this seems to occur only in |
alexkim205
approved these changes
Jan 28, 2022
| @@ -17,7 +17,7 @@ import { | |||
| TooltipModel, | |||
| TooltipOptions, | |||
| } from 'chart.js' | |||
| import { CrosshairOptions, CrosshairPlugin } from 'chartjs-plugin-crosshair' | |||
| import CrosshairPlugin, { CrosshairOptions } from 'chartjs-plugin-crosshair' | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I was getting these errors occasionally within
LineGraph:It appears the cause is
LineGraphreturning early (i.e. before all hooks run), which is prone to some race condition causing it NOT to return early at times, in which case all the V2 hooks get to run and make React extremely confused. The solution is to just refactor theLineGraphversion-choosing logic into a component of it's own that just renders the right actual component.