Insight card expandable details #8302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarkus
suggested changes
Jan 26, 2022
There was a problem hiding this comment.
Can we align the "global" insight filters to the design a bit more? They're a separate design in figma, but they could even match the query filters for each series/step. My main goal is to summarize as much as possible in a small area, so reducing the pill height to align with the query above would be a nice to have. Thoughts?
|
BTW this looks great! Nice job! |
|
Updated to include quick change that aligns with the step / graph filters. https://www.figma.com/file/gQBj9YnNgD8YW4nBwCVLZf?node-id=6212:32693#144888456
|
|
Sure @clarkus, updated: |
clarkus
approved these changes
Jan 27, 2022
pauldambra
approved these changes
Jan 28, 2022
|
👍 A possible use case for keeping multiple details open is comparing insights on the dashboard, so I'll run with it for now and see if users find it unintuitive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This implements an expandable "details" portion of
InsightCard'sInsightMeta. It will allow users to quickly get an understanding on what the insight represents right there on the dashboard, or in saved insights' card view. Design in Figma.