Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codecov/project shows random drops in coverage on main #1800

Open
wolfgangwalther opened this issue Apr 9, 2021 · 1 comment
Open

Codecov/project shows random drops in coverage on main #1800

wolfgangwalther opened this issue Apr 9, 2021 · 1 comment
Labels
ci Related to CI setup

Comments

@wolfgangwalther
Copy link
Member

Seems to happen every now and then, that the codecov/project statuscheck fails after merging PRs, that don't touch code at all.

Examples:

It seems that codecov calculates coverage from untracked files, too, somehow.
@wolfgangwalther wolfgangwalther added the ci Related to CI setup label Apr 9, 2021
wolfgangwalther added a commit to wolfgangwalther/postgrest that referenced this issue Apr 10, 2021
@wolfgangwalther
fix random codecov/project drops in CI, resolves PostgREST#1800
aba12c2 
Those are caused by running the spec tests with `-threaded`, which results in a race to write to spec.tix.
@wolfgangwalther wolfgangwalther mentioned this issue Apr 14, 2021
Merged
6 tasks
monacoremo pushed a commit to monacoremo/postgrest that referenced this issue Jul 17, 2021
@wolfgangwalther
fix random codecov/project drops in CI, resolves PostgREST#1800
57dcb61 
Those are caused by running the spec tests with `-threaded`, which results in a race to write to spec.tix.
@wolfgangwalther
Copy link
Member Author

Related:

Codecov: We introduced a 1% threshold to silence the random coverage fluctuations and resulting failures - for now, until we figure out their cause

#1903 (comment)

at

postgrest/.github/codecov.yml

Line 12 in 4e4548d

threshold: 1%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci Related to CI setup
Milestone
No milestone
Development

No branches or pull requests
2 participants
@steve-chavez @wolfgangwalther