fix UNKNOWN being shown as git commit hash (fixes #1530) #1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's a clean solution. I think it should be included as a fix on the CHANGELOG since it clears up the pgrst help text. |
Co-authored-by: Steve Chavez <stevechavezast@gmail.com>
|
@steve-chavez good idea, I added an entry to the changelog! |
Merged
6 tasks
monacoremo
added a commit
to monacoremo/postgrest
that referenced
this pull request
Jul 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1530
This might be a good compromise - it will show the commit hash in the help text if
.gitis available (e.g. when someone built PostgREST from source), but it will not showUNKNOWNif it's not.There are some cases where
.gitsimply can't be available (e.g. when cabal or nix build the package from a sdist tarball from Hackage), so this would give us the best of both worlds I think.Example when built with nix:
Example when built with stack: