Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return 405 Method not Allowed for GET of volatile RPC instead of 500 #1560

Merged

Conversation

wolfgangwalther
Copy link
Member

As discussed in #1552 (comment)

I changed the CHANGELOG to include this changed behaviour, but still need to change the docs, I guess ;)

@wolfgangwalther
Copy link
Member Author

(Not sure what's happening with GitHub right now. CI checks probably have to be manually triggered, once everything works again)

@wolfgangwalther
Copy link
Member Author

Pushed an empty commit to trigger a ci rebuild. Can be squashed away when merging.

@steve-chavez
Copy link
Member

Looks good!

I changed the CHANGELOG to include this changed behaviour, but still need to change the docs, I guess ;)
Adding the changelog item is hard on the first commit - because you have to guess the number of the PR. Let's see whether I guessed right.(from #1552 (comment))

Yeah, the CHANGELOG duplication is getting a bit tedious. I've opened PostgREST/postgrest-docs#340 to address this for the upcoming release.

@steve-chavez steve-chavez merged commit 8e4687f into PostgREST:master Jul 16, 2020
@wolfgangwalther wolfgangwalther deleted the volatile-get-method-not-allowed branch July 16, 2020 21:15
@jsommr
Copy link

jsommr commented Jul 18, 2020

Love it, these small increments of goodness, especially correct error handling, are super useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants