Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade nixpkgs to current master and add an upgrade checklist #1579

Merged

Conversation

monacoremo
Copy link
Member

This upgrades the PostgreSQL packages (including libpq linked into the static binary) to the newest patch releases from August (12.4, 11.9 etc.).

Also added a checklist that covers all necessary steps.

nix/UPGRADE.md Outdated
# Exit the nix-shell with Ctrl-d

# Alternatively, in one step
nix-shell --run nixpkgs-upgrade > nix/nixpkgs-version.nix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one gives me the following error in and outside of nix-shell:

error: while evaluating anonymous function at /home/steve-chavez/Projects/Haskell/postgrest/shell.nix:12:1, called from undefined position:
while evaluating the attribute 'pkgs' at /home/steve-chavez/Projects/Haskell/postgrest/default.nix:80:10:
syntax error, unexpected $end, at /home/steve-chavez/Projects/Haskell/postgrest/nix/nixpkgs-version.nix:1:1

The nix/nixpkgs-version.nix file contents get empty. I guess that's what the unexpected $end error means.

The nixpkgs-upgrade > nix/nixpkgs-version.nix version inside nix-shell works good though.

Is something missing on the command?

If the fix is not easy, maybe we can omit the one liner.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, weird - just tested it and it works for me. Maybe it's the nix-shell version? I'm on 2.3.7

But I guess it doesn't hurt to take out that line for now :-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes. I'm on 2.2.2. It's like bash redirection doesn't work on that version. Maybe a bug that got fixed.

@steve-chavez steve-chavez merged commit 7af54c5 into PostgREST:master Sep 10, 2020
@monacoremo monacoremo deleted the monacoremo-nixpkgs-upgrade-2020-09-04 branch September 10, 2020 05:47
monacoremo added a commit to monacoremo/postgrest that referenced this pull request Jul 17, 2021
…REST#1579)

* simplify haskell packages overrides based on new nixpkgs
* update Nix gitignore
* simplify Haskell packages overlay

Co-authored-by: monacoremo <monacoremo>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants