Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove io tests from stack-test because of random segmentation faults #1627

Merged
merged 1 commit into from
Oct 16, 2020

Conversation

wolfgangwalther
Copy link
Member

this is just to debug - nothing to merge, yet.

Right now, stack-test often fails with a segmentation fault during the io-tests. I tried to reproduce locally, but couldn't. Here, I ripped out all the other CI pipelines (no need to run them loads of times) and removed some > /dev/null redirections. Hopefully I can reproduce the error when running the CI pipeline a couple of times and get more useful logging output.

Let's see what happens.

@wolfgangwalther wolfgangwalther force-pushed the debug-ci-io-tests branch 12 times, most recently from af17fc4 to 1947f47 Compare October 16, 2020 14:57
@wolfgangwalther
Copy link
Member Author

Triggered the build 10 times, but the io failure didn't show up. Funny thing is... at the same time it happened in a different PR, but of course the extended logging was not enabled there.

I suggest to temporarily merge this into master and wait until the failure shows up again somewhere. Hopefully the bit of extra logging will then give us an idea how to proceed. The io tests will not look nice during that time, but that should be ok.

@wolfgangwalther wolfgangwalther marked this pull request as ready for review October 16, 2020 14:59
@wolfgangwalther
Copy link
Member Author

wolfgangwalther commented Oct 16, 2020

Alternatively, we could just remove the io test suite from stack-test. The io tests are run in nix-build-test anyway and have never shown that same error there so far. So it seems to be very much an issue with the ci setup, not the tests or even postgrest (I assume it is some concurrency issue related to caching again, that we had a couple of times, but not sure on that).

@steve-chavez
Copy link
Member

Alternatively, we could just remove the io test suite from stack-test. The io tests are run in nix-build-test anyway and have never shown that same error there so far

I've thought of that as well. I'd agree with that change.

@wolfgangwalther wolfgangwalther changed the title debug io tests in ci remove io tests from stack-test because of random segmentation faults Oct 16, 2020
@wolfgangwalther
Copy link
Member Author

so be it! changed!

@steve-chavez steve-chavez merged commit b7b66b6 into PostgREST:master Oct 16, 2020
@wolfgangwalther wolfgangwalther deleted the debug-ci-io-tests branch October 16, 2020 20:48
monacoremo pushed a commit to monacoremo/postgrest that referenced this pull request Jul 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants