ci: run spec tests against all pg versions, even if one of them fails #1628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is only about the nix-build-test step and it works well:
I left the commits in here, so you can still see the pipeline results easily. Please squash this when merging. Ready to merge. |
Yeah! This is the way it used to work before as well with different circle jobs for each pg test. Nice improvement :) Merging.. 🚀 |
6 tasks
monacoremo
pushed a commit
to monacoremo/postgrest
that referenced
this pull request
Jul 17, 2021
…PostgREST#1628) - when the build fails no tests are run(circleci-agent step halt) - when the build succeeds all tests are run, even if some of them fail(when: always)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the spec tests fail only for older pg versions. It would be cool, if the spec tests would still be run against all versions, even if one of them fails, to get a quick overview of the problem with different versions.
This change tries to do that. I will temporarily push a couple of errors after the first build to confirm it is working as expected.