Enhancements for AUTO protocol search #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
request when using AUTO protocol
…into Protocol-fix
|
There's a lot more whitespace edits than I was expecting, but for now I will trust all the commits will be ok and not break things. I will not be able to personally test in the near future - once I do test and verify, I'll tag out a new version, but not sooner. |
|
Yeah, I think I should have squashed those edits into one commit. N00b mistake, first PR on GitHub. Cheers, and thanks for ELMDuino. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic searching for protocol requires setting the protocol to AUTO and then sending an OBD command to initiate the protocol search. The OBD command "0100" requests a list of supported PIDs 0x00 - 0x20 and is guaranteed to work. This change also temporarily changes the timeout value to 30 sec allow the protocol search to complete.