lower number of allowed compression loops in getLabelFromContent()

mind04 · mind04 · commit 032d565786fb · 2015-04-13T14:25:29.000+02:00
1000 is a bit high for a max 255 character qname
diff --git a/pdns/dnsparser.cc b/pdns/dnsparser.cc
@@ -455,7 +455,7 @@ string PacketReader::getText(bool multi)
 
 void PacketReader::getLabelFromContent(const vector<uint8_t>& content, uint16_t& frompos, string& ret, int recurs) 
 {
-  if(recurs > 1000) // the forward reference-check below should make this test 100% obsolete
+  if(recurs > 100) // the forward reference-check below should make this test 100% obsolete
     throw MOADNSException("Loop");
 
   int pos = frompos;

Original file line number	Diff line number	Diff line change
`@@ -455,7 +455,7 @@ string PacketReader::getText(bool multi)`
`455`	`455`
`456`	`456`	`void PacketReader::getLabelFromContent(const vector<uint8_t>& content, uint16_t& frompos, string& ret, int recurs)`
`457`	`457`	`{`
`458`		`- if(recurs > 1000) // the forward reference-check below should make this test 100% obsolete`
	`458`	`+ if(recurs > 100) // the forward reference-check below should make this test 100% obsolete`
`459`	`459`	`throw MOADNSException("Loop");`
`460`	`460`
`461`	`461`	`int pos = frompos;`