Skip to content

Commit 088c334

Browse files
author
Ruben d'Arco
committed
output warning message when no to be notified NS's are found
fixes #926
1 parent ec2b2d4 commit 088c334

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

pdns/mastercommunicator.cc

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@
3939

4040
void CommunicatorClass::queueNotifyDomain(const string &domain, DNSBackend *B)
4141
{
42+
bool hasQueuedItem=false;
4243
set<string> ips;
4344
FindNS fns;
4445

@@ -60,14 +61,19 @@ void CommunicatorClass::queueNotifyDomain(const string &domain, DNSBackend *B)
6061
for(set<string>::const_iterator j=ips.begin();j!=ips.end();++j) {
6162
L<<Logger::Warning<<"Queued notification of domain '"<<domain<<"' to "<<*j<<endl;
6263
d_nq.add(domain,*j);
64+
hasQueuedItem=true;
6365
}
6466
set<string>alsoNotify;
6567
B->alsoNotifies(domain, &alsoNotify);
6668

6769
for(set<string>::const_iterator j=alsoNotify.begin();j!=alsoNotify.end();++j) {
6870
L<<Logger::Warning<<"Queued also-notification of domain '"<<domain<<"' to "<<*j<<endl;
6971
d_nq.add(domain,*j);
72+
hasQueuedItem=true;
7073
}
74+
if (!hasQueuedItem)
75+
L<<Logger::Warning<<"Request to queue notification for domain '"<<domain<<"' was processed, but no nameservers or also-notify's found. Not notifying!"<<endl;
76+
7177
}
7278

7379
bool CommunicatorClass::notifyDomain(const string &domain)

0 commit comments

Comments
 (0)