Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth: new default param for ifurlup/ifportup lua functions to control… #12558

Closed

Conversation

chbruyand
Copy link
Member

… default answer (prior to any check)

Short description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@Habbie
Copy link
Member

Habbie commented Feb 21, 2023

Want to write docs and a test?

@chbruyand
Copy link
Member Author

chbruyand commented Mar 21, 2023

Closing as this doesn't provide anything useful. First call to if*up() function will result in all tests being negative, so we will fallback to use the desired selector on ALL ips (which is the same set as considering all ips up in the first place).

@chbruyand chbruyand closed this Mar 21, 2023
@thestinger
Copy link

It's not the same as the case where there are multiple sets though. It uses the combination of all the sets for the fallback instead of the first set. Filed #12789. I think the behavior should just be changed to make all IPs being up and all IPs being down return the same result (selector on first set) without needing an option to control it. I can't think of a use case for the current behavior over that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants