Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Switch to our fork of h2o to mitigate http2 rapid reset #13348

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

rgacogne
Copy link
Member

Short description

Testing in progress at https://github.com/rgacogne/pdns/actions/runs/6480831098

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne
Copy link
Member Author

I just realized I probably need to bump the Debian revision, looking into how this is done.

@Habbie
Copy link
Member

Habbie commented Oct 11, 2023

I just realized I probably need to bump the Debian revision, looking into how this is done.

Just bumping the normal version should be more than enough I think?

@mnordhoff
Copy link
Contributor

I know the curl commands were already there, but it might be good to add the -f option?

(HTTP) Fail fast with no output at all on server errors. This is useful to enable scripts and users to better deal with failed attempts. In normal cases when an HTTP server fails to deliver a document, it returns an HTML document stating so (which often also describes why and more). This flag prevents curl from outputting that and return error 22.

This method is not fail-safe and there are occasions where non-successful response codes slip through, especially when authentication is involved (response codes 401 and 407).

@rgacogne
Copy link
Member Author

I know the curl commands were already there, but it might be good to add the -f option?

(HTTP) Fail fast with no output at all on server errors. This is useful to enable scripts and users to better deal with failed attempts. In normal cases when an HTTP server fails to deliver a document, it returns an HTML document stating so (which often also describes why and more). This flag prevents curl from outputting that and return error 22.
This method is not fail-safe and there are occasions where non-successful response codes slip through, especially when authentication is involved (response codes 401 and 407).

Sounds like a good idea, thanks!

@rgacogne rgacogne merged commit a68b083 into PowerDNS:master Oct 11, 2023
73 checks passed
@rgacogne rgacogne deleted the ddist-powerdns-h2o-h2-rapid-reset branch October 11, 2023 10:39
@coveralls
Copy link

coveralls commented Oct 11, 2023

Pull Request Test Coverage Report for Build 6481015043

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 28 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.03%) to 56.347%

Files with Coverage Reduction New Missed Lines %
pdns/distributor.hh 2 52.17%
pdns/tcpiohandler.cc 2 66.89%
pdns/recursordist/negcache.hh 3 78.43%
pdns/recursordist/test-syncres_cc2.cc 3 88.99%
pdns/sodcrypto.cc 3 89.02%
pdns/recursordist/test-syncres_cc1.cc 6 88.95%
pdns/dnsdist-carbon.cc 9 57.03%
Totals Coverage Status
Change from base Build 6457253306: 0.03%
Covered Lines: 102316
Relevant Lines: 151126

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants