-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use OpenResty Luajit Package with wforce #425
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
halfway through I realised you checked in more than you intended, so I'll continue my review when you cleaned up
Yes thanks, I didn't run cleanup.sh after a local testing run... |
a bit of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not read every line, but the general shape looks good. build.sh
works on my system, tests pass. Approved (with a double nit from my previous review)
Indeed, will do this before I merge,
Neil
… On 7 Jun 2024, at 11:53, Peter van Dijk ***@***.***> wrote:
Yes thanks, I didn't run cleanup.sh after a local testing run...
a bit of .gitignore can prevent future accidents
—
Reply to this email directly, view it on GitHub <#425 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADS27WB7FUPXV2WI7YBNM2LZGGGI5AVCNFSM6AAAAABIYTBB22VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJUGU4TAOBXGM>.
You are receiving this because you authored the thread.
|
Regular luajit provided with many distros has memory allocation issues that causes crashes. These issues are fixed in the OpenResty fork of LuaJIT. This PR packages up the OpenResty fork of LuaJIT, and compiles wforce against. The luajit package also include various lua modules that are interesting and useful for wforce such as luasec, elasticsearch and lualdap. Such modules are often only available as packages for later versions of Lua, not Lua 5.1 which is what LuaJIT requires.
This PR also adds support for debian bookworm and drops support for debian buster.
General tidying of the packaging dockerfiles is also part of the PR in order to take better advantage of docker caching/multi-stage builds to improve performance.