Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OpenResty Luajit Package with wforce #425

Merged
merged 13 commits into from
Jun 10, 2024
Merged

Conversation

neilcook
Copy link
Collaborator

@neilcook neilcook commented Jun 4, 2024

Regular luajit provided with many distros has memory allocation issues that causes crashes. These issues are fixed in the OpenResty fork of LuaJIT. This PR packages up the OpenResty fork of LuaJIT, and compiles wforce against. The luajit package also include various lua modules that are interesting and useful for wforce such as luasec, elasticsearch and lualdap. Such modules are often only available as packages for later versions of Lua, not Lua 5.1 which is what LuaJIT requires.

This PR also adds support for debian bookworm and drops support for debian buster.

General tidying of the packaging dockerfiles is also part of the PR in order to take better advantage of docker caching/multi-stage builds to improve performance.

Copy link

github-actions bot commented Jun 4, 2024

Test Results

  2 files  ±0    2 suites  ±0   32m 9s ⏱️ -4s
 70 tests ±0   70 ✅ ±0  0 💤 ±0  0 ❌ ±0 
140 runs  ±0  140 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 4bde348. ± Comparison against base commit 97ef80a.

♻️ This comment has been updated with latest results.

Copy link
Member

@Habbie Habbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

halfway through I realised you checked in more than you intended, so I'll continue my review when you cleaned up

builder-support/dockerfiles/Dockerfile.debbuild Outdated Show resolved Hide resolved
builder-support/dockerfiles/Dockerfile.rpmbuild Outdated Show resolved Hide resolved
luaenv/target/bin/luajit Outdated Show resolved Hide resolved
luaenv/target/bin/luarocks Outdated Show resolved Hide resolved
@neilcook
Copy link
Collaborator Author

neilcook commented Jun 7, 2024

halfway through I realised you checked in more than you intended, so I'll continue my review when you cleaned up

Yes thanks, I didn't run cleanup.sh after a local testing run...

@Habbie
Copy link
Member

Habbie commented Jun 7, 2024

Yes thanks, I didn't run cleanup.sh after a local testing run...

a bit of .gitignore can prevent future accidents

Copy link
Member

@Habbie Habbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not read every line, but the general shape looks good. build.sh works on my system, tests pass. Approved (with a double nit from my previous review)

@neilcook
Copy link
Collaborator Author

neilcook commented Jun 7, 2024 via email

@neilcook neilcook merged commit a0c72ae into PowerDNS:master Jun 10, 2024
12 checks passed
@neilcook neilcook deleted the luajit branch June 10, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants