This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
Fix unreliable WindowsProcess tests (Fixes #70) #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #73 +/- ##
===================================
Coverage 83% 83%
===================================
Files 19 19
Lines 2753 2753
Branches 4 4
===================================
Hits 2296 2296
Misses 453 453
Partials 4 4 |
|
Reviewed 6 of 6 files at r1. Comments from Reviewable |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the integration tests for WindowsProcess were having intermittent timing issues with the log files.
I have updated these tests to fix this.
The tests should now also no longer be dependent on each other.
This fixes #70
This change is