-
Notifications
You must be signed in to change notification settings - Fork 100
#969: Inject credentials to ISettings to pass them into PushRunner #993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityapatwardhan
requested changes
May 3, 2023
Co-authored-by: Aditya Patwardhan <adityap@microsoft.com>
Co-authored-by: Aditya Patwardhan <adityap@microsoft.com>
Co-authored-by: Aditya Patwardhan <adityap@microsoft.com>
Co-authored-by: Aditya Patwardhan <adityap@microsoft.com>
alerickson
approved these changes
May 5, 2023
adityapatwardhan
requested changes
May 5, 2023
Co-authored-by: Aditya Patwardhan <adityap@microsoft.com>
Co-authored-by: Aditya Patwardhan <adityap@microsoft.com>
anamnavi
approved these changes
May 5, 2023
3 tasks
adityapatwardhan
approved these changes
May 5, 2023
Hi all, I'd like to test this change but based on the CHANGELOG this didn't make it into |
@dbrennand thanks for pointing this out. I forgot to include this in the changelog, but it should be included in the beta21 code changes. We're aiming to release later today so the changes would be included when it releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Inject credentials passed to
Publish-PSResource
intoISettings
object in order to pass them along to thePushRunner
that pushes the .nupkg to the feed.Should solve #969
PR Context
This allows publishing PS resources to an authenticated feed.
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.