Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the 32,767 character limit on the environment block for Start-Process #14111

Merged

Conversation

hbuckle
Copy link
Contributor

@hbuckle hbuckle commented Nov 17, 2020

PR Summary

Remove the 32,767 character limit on the environment block for Start-Process
fixes #14110

PR Context

This limit only applied to Windows XP/Server 2003 - newer versions of Windows have no limitation (source)

PR Checklist

@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Nov 18, 2020
@MattJeanes
Copy link

This pull request indirectly fixes a accidental breaking change in PowerShell 7.0 -> 7.1 which affects most notably Azure DevOps pipelines with many artifacts - is this going to make it into a patch release soon? We're having to add work arounds to our code now for the linked issue as Azure Pipelines agents have updated to PowerShell 7.1.

@ghost ghost added the Review - Needed The PR is being reviewed label Dec 2, 2020
@ghost
Copy link

ghost commented Dec 2, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@adityapatwardhan
Copy link
Member

@TravisEz13 Can you review

@ghost ghost removed the Review - Needed The PR is being reviewed label Mar 2, 2021
@TravisEz13 TravisEz13 merged commit 9aede05 into PowerShell:master Mar 2, 2021
@adityapatwardhan adityapatwardhan added BackPort-7.1.x-Done Backport to 7.1.x completed and removed BackPort-7.1.x-Approved labels Mar 9, 2021
@ghost
Copy link

ghost commented Mar 11, 2021

🎉v7.1.3 has been released which incorporates this pull request.:tada:

Handy links:

WamWooWam pushed a commit to WamWooWam/PowerShell that referenced this pull request Mar 16, 2021
WamWooWam added a commit to WamWooWam/PowerShell that referenced this pull request Mar 16, 2021
[7.1.3] - 2021-03-11

*** Engine Updates and Fixes

- Remove the 32K character limit on the environment block for `Start-Process` (PowerShell#14111)
- Fix webcmdlets to properly construct URI from body when using `-NoProxy` (PowerShell#14673)

*** General Cmdlet Updates and Fixes

- Fix `PromptForCredential()` to add `targetName` as domain (PowerShell#14504)

*** Build and Packaging Improvements

<details>

<summary>

Bump .NET SDK to 5.0.4

</summary>

<ul>
<li>Bump .NET SDK to 5.0.4 (Internal 14775)</li>
<li>Disable running markdown link verification in release build CI (PowerShell#14971, PowerShell#14974, PowerShell#14975)</li>
<li>Use template that disables component governance for CI (PowerShell#14938)</li>
<li>Declare which variable group is used for checking the blob in the release build (PowerShell#14970)</li>
<li>Add suppress for nuget multi-feed warning (PowerShell#14893)</li>
<li>Disable code signing validation where the file type is not supported (PowerShell#14885)</li>
<li>Install wget on <code>CentOS</code> 7 docker image (PowerShell#14857)</li>
<li>Fix install-dotnet download (PowerShell#14856)</li>
<li>Make universal Deb package based on deb package spec (PowerShell#14681)</li>
<li>Fix release build to upload global tool packages to artifacts (PowerShell#14620)</li>
<li>Update <code>ini</code> component version in test <code>package.json</code> (PowerShell#14454)</li>
<li>Add manual release automation steps and improve changelog script (PowerShell#14445)</li>
<li>Update markdown test packages with security fixes (PowerShell#14145)</li>
<li>Fix a typo in the <code>Get-ChangeLog</code> function (PowerShell#14129)</li>
<li>Disable global tool copy to unblock release</li>
</ul>

</details>

[7.1.3]: PowerShell/PowerShell@v7.1.2...v7.1.3
@ghost
Copy link

ghost commented Mar 16, 2021

🎉v7.2.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BackPort-7.1.x-Done Backport to 7.1.x completed CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Start-Process fails with EnvironmentBlockTooLong error
6 participants