Make universal Deb package based on deb package spec #14681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravisEz13
requested review from
adityapatwardhan,
anmenaga and
daxian-dbw
as code owners
|
verified on buster and 20.04. |
TravisEz13
changed the title
TravisEz13
commented
Jan 29, 2021
|
Restarted CI for failed 'RemoteSession.Disconnect.Tests.ps1' |
| "zlib1g" | ||
| "zlib1g", | ||
| "libicu72|libicu71|libicu70|libicu69|libicu68|libicu67|libicu66|libicu65|libicu63|libicu60|libicu57|libicu55|libicu52", | ||
| "libssl1.1|libssl1.0.2|libssl1.0.0" |
There was a problem hiding this comment.
with this change it looks like we are eliminating the unsupported error when faced with a platform we don't understand. Does that mean we are relying on an error generated when the dependency is not found rather than a specific version?
There was a problem hiding this comment.
yes, basically, but that was only a build time error. Since the attempt here is to build a universal, package, keeping the error didn't make since.
If we hit a platform that has a missing dependency, then we should add it to the list if supported or not if the platform is not.
JamesWTruher
approved these changes
Jan 29, 2021
anmenaga
approved these changes
Feb 2, 2021
iSazonov
added
the
CL-BuildPackaging
|
🎉 Handy links: |
ghost
mentioned this pull request
adityapatwardhan
added
BackPort-7.0.x-Approved
BackPort-7.1.x-Done
daxian-dbw
pushed a commit
to daxian-dbw/PowerShell
that referenced
this pull request
Mar 11, 2021
|
🎉 Handy links: |
|
🎉 Handy links: |
WamWooWam
pushed a commit
to WamWooWam/PowerShell
that referenced
this pull request
Mar 16, 2021
WamWooWam
added a commit
to WamWooWam/PowerShell
that referenced
this pull request
Mar 16, 2021
[7.1.3] - 2021-03-11 *** Engine Updates and Fixes - Remove the 32K character limit on the environment block for `Start-Process` (PowerShell#14111) - Fix webcmdlets to properly construct URI from body when using `-NoProxy` (PowerShell#14673) *** General Cmdlet Updates and Fixes - Fix `PromptForCredential()` to add `targetName` as domain (PowerShell#14504) *** Build and Packaging Improvements <details> <summary> Bump .NET SDK to 5.0.4 </summary> <ul> <li>Bump .NET SDK to 5.0.4 (Internal 14775)</li> <li>Disable running markdown link verification in release build CI (PowerShell#14971, PowerShell#14974, PowerShell#14975)</li> <li>Use template that disables component governance for CI (PowerShell#14938)</li> <li>Declare which variable group is used for checking the blob in the release build (PowerShell#14970)</li> <li>Add suppress for nuget multi-feed warning (PowerShell#14893)</li> <li>Disable code signing validation where the file type is not supported (PowerShell#14885)</li> <li>Install wget on <code>CentOS</code> 7 docker image (PowerShell#14857)</li> <li>Fix install-dotnet download (PowerShell#14856)</li> <li>Make universal Deb package based on deb package spec (PowerShell#14681)</li> <li>Fix release build to upload global tool packages to artifacts (PowerShell#14620)</li> <li>Update <code>ini</code> component version in test <code>package.json</code> (PowerShell#14454)</li> <li>Add manual release automation steps and improve changelog script (PowerShell#14445)</li> <li>Update markdown test packages with security fixes (PowerShell#14145)</li> <li>Fix a typo in the <code>Get-ChangeLog</code> function (PowerShell#14129)</li> <li>Disable global tool copy to unblock release</li> </ul> </details> [7.1.3]: PowerShell/PowerShell@v7.1.2...v7.1.3
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Try to make universal Deb package based on deb package spec
PR Context
Maybe?
fixes #13759
https://www.debian.org/doc/debian-policy/ch-relationships.html
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.