-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix webcmdlets to properly construct URI from body when using -NoProxy #14673
Conversation
…t to handle CustomMethodNoProxy case
The codefactor issues pertain to existing style in that file. The changes follow the current style. Updating the entire file is not in scope of this PR. |
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
@iSazonov ready to merge? |
🎉 Handy links: |
🎉 Handy links: |
🎉 Handy links: |
[7.1.3] - 2021-03-11 *** Engine Updates and Fixes - Remove the 32K character limit on the environment block for `Start-Process` (PowerShell#14111) - Fix webcmdlets to properly construct URI from body when using `-NoProxy` (PowerShell#14673) *** General Cmdlet Updates and Fixes - Fix `PromptForCredential()` to add `targetName` as domain (PowerShell#14504) *** Build and Packaging Improvements <details> <summary> Bump .NET SDK to 5.0.4 </summary> <ul> <li>Bump .NET SDK to 5.0.4 (Internal 14775)</li> <li>Disable running markdown link verification in release build CI (PowerShell#14971, PowerShell#14974, PowerShell#14975)</li> <li>Use template that disables component governance for CI (PowerShell#14938)</li> <li>Declare which variable group is used for checking the blob in the release build (PowerShell#14970)</li> <li>Add suppress for nuget multi-feed warning (PowerShell#14893)</li> <li>Disable code signing validation where the file type is not supported (PowerShell#14885)</li> <li>Install wget on <code>CentOS</code> 7 docker image (PowerShell#14857)</li> <li>Fix install-dotnet download (PowerShell#14856)</li> <li>Make universal Deb package based on deb package spec (PowerShell#14681)</li> <li>Fix release build to upload global tool packages to artifacts (PowerShell#14620)</li> <li>Update <code>ini</code> component version in test <code>package.json</code> (PowerShell#14454)</li> <li>Add manual release automation steps and improve changelog script (PowerShell#14445)</li> <li>Update markdown test packages with security fixes (PowerShell#14145)</li> <li>Fix a typo in the <code>Get-ChangeLog</code> function (PowerShell#14129)</li> <li>Disable global tool copy to unblock release</li> </ul> </details> [7.1.3]: PowerShell/PowerShell@v7.1.2...v7.1.3
PR Summary
Due to complexity of parameters with the webcmdlets, they are handled at runtime in code rather than just through parametersets. In this case, the body can be provided as a dictionary which is used to construct query parameters appended to the URI. The logic of that code checks if the cmdlet is currently using the
StandardMethodSet
before constructing the query. However,-NoProxy
is in theStandardMethodNoProxy
so when that switch is used, then the body doesn't get turned into query parameters.The fix is to change the
IsStandardMethodSet()
to return true if the current parameterset is eitherStandardMethod
orStandardMethodNoProxy
. And same change forCustomMethod
andCustomMethodNoProxy
check.PR Context
This was reported by a customer directly to Microsoft through premier support.
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.