Regression: Most of FileInfo object properties is missing in debug view

Fixes #1649

Author: JustinGrote

src/PowerShellEditorServices/Services/DebugAdapter/Debugging/VariableDetails.cs

@@ -279,6 +279,8 @@ private VariableDetails[] GetChildren(object obj, ILogger logger)
                     childVariables.AddRange(
                         psObject
                             .Properties
+                            // Exclude Script properties. TODO: Marshal script properties back to runspace
+                            .Where(p => p.MemberType != PSMemberTypes.ScriptProperty)
                             .Select(p => new VariableDetails(p)));
                 }
                 else
@@ -293,7 +295,11 @@ private VariableDetails[] GetChildren(object obj, ILogger logger)
                                 // Here we check the object's MemberType against the `Properties`
                                 // bit-mask to determine if this is a property. Hence the selection
                                 // will only include properties.
-                                .Where(p => (PSMemberTypes.Properties & p.MemberType) is not 0)
+                                .Where(p =>
+                                    (PSMemberTypes.Properties & p.MemberType) is not 0 &&
+                                    // Exclude Script properties. TODO: Marshal script properties back to runspace
+                                    p.MemberType != PSMemberTypes.ScriptProperty
+                                )
                                 .Select(p => new VariableDetails(p)));
 
                         obj = psObject.BaseObject;

test/PowerShellEditorServices.Test.Shared/Debugging/VariableFileInfoTest.ps1

@@ -0,0 +1,2 @@
+$fileInfoItem = Get-Item $PSScriptRoot/DebugFileInfoTest.ps1
+'Done'

test/PowerShellEditorServices.Test/Debugging/DebugServiceTests.cs

@@ -28,6 +28,7 @@ public class DebugServiceTests : IDisposable
         private readonly WorkspaceService workspace;
         private readonly ScriptFile debugScriptFile;
         private readonly ScriptFile variableScriptFile;
+        private readonly ScriptFile variableFileInfoTestFile;
 
         public DebugServiceTests()
         {
@@ -56,6 +57,7 @@ public DebugServiceTests()
             workspace = new WorkspaceService(NullLoggerFactory.Instance);
             debugScriptFile = GetDebugScript("DebugTest.ps1");
             variableScriptFile = GetDebugScript("VariableTest.ps1");
+            variableFileInfoTestFile = GetDebugScript("VariableFileInfoTest.ps1");
         }
 
         public void Dispose()
@@ -101,6 +103,8 @@ private Task ExecutePowerShellCommand(string command, params string[] args)
 
         private Task ExecuteVariableScriptFile() => ExecutePowerShellCommand(variableScriptFile.FilePath);
 
+        private Task ExecuteVariableFileInfoTest() => ExecutePowerShellCommand(variableFileInfoTestFile.FilePath);
+
         private void AssertDebuggerPaused()
         {
             var eventArgs = debuggerStoppedQueue.Take(new CancellationTokenSource(5000).Token);
@@ -528,6 +532,26 @@ await debugService.SetLineBreakpointsAsync(
             Assert.False(var.IsExpandable);
         }
 
+        // [Trait("Category", "DebugService")]
+        // [Fact]
+        // public async Task DebuggerFileInfoHasAllProperties()
+        // {
+        //     await debugService.SetLineBreakpointsAsync(
+        //         variableFileInfoTestFile,
+        //         new[] { BreakpointDetails.Create(variableFileInfoTestFile.FilePath, 2) }).ConfigureAwait(true);
+
+        //     Task _ = ExecuteVariableFileInfoTest();
+        //     AssertDebuggerStopped(variableFileInfoTestFile.FilePath);
+
+        //     StackFrameDetails[] stackFrames = await debugService.GetStackFramesAsync().ConfigureAwait(true);
+        //     VariableDetailsBase[] variables = debugService.GetVariables(stackFrames[0].AutoVariables.Id);
+
+        //     var var = Array.Find(variables, v => v.Name == "$fileInfoItem");
+        //     Assert.NotNull(var);
+        //     Assert.Equal("\"Hello\"", var.ValueString);
+        //     Assert.False(var.IsExpandable);
+        // }
+
         [Trait("Category", "DebugService")]
         [Fact]
         public async Task DebuggerGetsVariables()