French characters are not displayed correctly when debugging

[neothoms]

System Details Output

- Operating system name and version : Windows 10 Version 10.0.17763 Numéro 17763
- VS Code version  : 1.30.1
- PowerShell extension version : 1.10.2
- Output from `$PSVersionTable`
### VSCode version: 1.30.1 dea8705087adb1b5e5ae1d9123278e178656186a x64

### VSCode extensions:
hbenl.vscode-firefox-debug@1.7.3
heaths.vscode-guid@1.4.0
MS-CEINTL.vscode-language-pack-fr@1.30.2
ms-vscode.csharp@1.17.1
ms-vscode.PowerShell@1.10.2
msjsdiag.debugger-for-chrome@4.11.1
robertohuertasm.vscode-icons@8.0.0


### PSES version: 1.10.2.0

### PowerShell version:

Name                           Value
----                           -----
PSVersion                      5.1.17763.134
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.17763.134
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1



<!-- PowerShell output from above goes here -->

Issue Description

I am experiencing a problem with French characters wich are not correctly reproduced on VS Integrated console but it may also apears with any special characters from any language.

Expected Behaviour

When I type the following command directly in the console everything is displayed correctly.
write-host "---- These are french characters : âà ç éèë ïï and they are not correctly displayed ----"

Actual Behaviour

But if I use the powershell extension and type the same command in a .ps1 file encoded in UTF8 I have this incorrect result :

Attached Logs

Follow the instructions in the troubleshooting docs
about capturing and sending logs.

[SydneyhSmith]

@neothoms thanks for reporting this! The command you are running is provided by VSCode and it just pastes the path of the open file into the active terminal followed by an "enter" key, so it is likely that the issue is on the VSCode side: looks related to this issue microsoft/vscode#31366

[ubidev]

Seems to be affecting variables definition too...
1- In vscode I get this error:

2- When I open the same fine in ISE, I get this:

3- I then correct/save/run the same file in ISE with this result:

4- Finally, back in vscode,it displays like this, but runs ok !!!

Hope this helps
win 10 ent 1809 latest patches
vscode 1.30.1
ms-vscode.PowerShell@1.10.2

PSVersion 5.1.17763.134
PSEdition Desktop
PSCompatibleVersions {1.0, 2.0, 3.0, 4.0...}
BuildVersion 10.0.17763.134
CLRVersion 4.0.30319.42000
WSManStackVersion 3.0
PSRemotingProtocolVersion 2.3
SerializationVersion 1.1.0.1

[rjmholt]

This is an encoding problem that occurs with file handling between VSCode and the ISE. Please see #1351 and #1306 (comment).

There's not much we can do from the extension's perspective -- the solution lies in ensuring you have VSCode, the ISE and PowerShell all configured to use UTF-8. The encoding problems you're seeing are (for example) due to the é being encoded in UTF-8 as 0xC3 0xA9 and then being interpreted as CP-1252/ISO-8859-1/latin-1 by PowerShell as the characters é (handy reference).

You need to set PowerShell's encoding to UTF-8, or VSCode's to ISO-8859-1, and make sure the ISE is also configured to do the same. The encoding settings of all your tools need to be set to the same encoding.

Because PowerShell defaults to CP-1252 for things like this, but VSCode defaults to UTF-8, you will need to make a conscious choice as to how you encode your scripts in source control and how you configure the encoding in your editors and PowerShell. If they get out of sync, they may all try to re-encode files and cause problems again.

[ubidev]

I understand your points.
I was always impressed since ISE v3 being able to handle french and spanish strings out to console output without a hitch. even localized variable names is not a problem.
Do you know how to configure then vscode to default to the same character support as ISE then? (UTF-8 with BOM) when creating new powershell files?

Thanks in advance

[rjmholt]

ISE v3 being able to handle french and spanish strings out to console output without a hitch. even localized variable names is not a problem

That's probably because all the required characters lie within the CP-1252 codepage. The problem now is that the upper half of CP-1252 characters are incompatible with UTF-8.

It looks like you are creating the PowerShell files as UTF-8, but PowerShell is trying to read them as CP-1252. So you need to change the encoding in the integrated terminal (which is just a matter of setting the .NET settings as in normal PowerShell). This is probably best done in your profile.

For setting editor encodings, see #1308 (comment).

[rjmholt]

It sounds like it might be helpful for us to summarise this in a document.

But I should emphasise that the encoding problems stem from having editor, PowerShell and source control settings out of sync. There's nothing the extension can really magically do without being opinionated (and therefore breaking people).

[ubidev]

coz usually if I follow the following workflow the french characters are always displayed ok at every step, even in source control

• Creation: ISE or Notepad++ (set to UTF-8 with BOM)
• Edits: VSCODE
  -Publish: GITLAB then VSTS

thanks for the very appreciated enlightenment and have a great day

[ubidev]

I totally agree :)

[rjmholt]

Creation: ISE or Notepad++ (set to UTF-8 with BOM)

I think the only caveat is that you need to ensure that ISE is configured to use UTF-8. The annoying part in VSCode is that because it's client/server, you need to configure both VSCode and the Integrated Terminal separately.

thanks for the very appreciated enlightenment and have a great day

Thank you! Let us know if you continue to experience issues. Encoding in PowerShell is a problem with no simple solutions, but we are definitely interested in feedback to make it all work as best we can.

[ubidev]

Unfortunately, I can't do that. If I use UTF8 in ISE/VSCODE/NPP for example, all hell breaks loose at execution: variables contaning accented characters break, display strings too.

The only way it works flawlessy at each step of the way on my computers/vms set to Windows english plus french lang pack is if I create the powershell scripts in "UTF8 with BOM" (default behavior in ISE, manual config in NPP)
Then execution, console outputs, gui popups, git/vsts repos contents display perfectly !
That's why I need to configure vscode to create in UTF-8 with BOM by default so I can use vscode only. :)
Obviously, I could forego the use of such characters and do everything in english but unfortunately, this is not an option where I live for many private projects requirements for naming conventions, outputs and documentation.
Thanks again for your time