Add new powershell.codeFormatting settings for new options in PSSA 1.18: WhitespaceInsideBrace and WhitespaceAroundPipe #1668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… powershell.codeFormatting.WhitespaceAroundPipe
|
The depending PSSA PR has been merged now (meaning the feature will be in 1.18), so only the release is blocking the PR from merging, can you please start the review @TylerLeonhardt or @rjmholt in the meantime? |
rjmholt
changed the title
|
(Taken the merge note out, since we won't release before PSSA does) |
rjmholt
approved these changes
Mar 5, 2019
rkeithhill
reviewed
Mar 5, 2019
package.json
Outdated
| "powershell.codeFormatting.WhitespaceInsideBrace": { | ||
| "type": "boolean", | ||
| "default": true, | ||
| "description": "Adds a space after an opening brace ('}') and before a closing brace ('}')." |
There was a problem hiding this comment.
You say "opening brace" but then use a closing brace as an example. I think that should be ('{').
There was a problem hiding this comment.
Well spotted, thanks. I fixed it
rkeithhill
reviewed
Mar 5, 2019
package.json
Outdated
| "powershell.codeFormatting.WhitespaceAroundPipe": { | ||
| "type": "boolean", | ||
| "default": true, | ||
| "description": "Adds a space before and after a pipeline ('|')." |
There was a problem hiding this comment.
I think we should refer to this symbol as it is referred to in the docs "pipeline operator" e.g. "... before and after the pipeline operator ('|').".
bergmeister
commented
Mar 6, 2019
bergmeister
commented
Mar 6, 2019
bergmeister
pushed a commit
to bergmeister/vscode-powershell
that referenced
this pull request
Mar 20, 2019
…18: WhitespaceInsideBrace and WhitespaceAroundPipe (PowerShell#1668) * Add new settings: powershell.codeFormatting.WhitespaceInsideBrace and powershell.codeFormatting.WhitespaceAroundPipe * fix whitespace * Apply suggestions from code review
This was referenced Mar 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR exposes new settings to use the new PSSA settings from this PR.
The corresponding PR in PSES is here
This PR can only be merged once PSSA 1.18 has released and the dependent PSES has been merged.
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready