turn off non-windows gate for attach to process #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkeithhill
reviewed
Jan 28, 2019
src/features/DebugSession.ts
Outdated
| @@ -68,7 +68,8 @@ export class DebugSessionFeature implements IFeature, DebugConfigurationProvider | |||
| const platformDetails = getPlatformDetails(); | |||
| const versionDetails = this.sessionManager.getPowerShellVersionDetails(); | |||
|
|
|||
| if (platformDetails.operatingSystem !== OperatingSystem.Windows) { | |||
| // Cross-platform attach to process was added in 6.2.0-preview.4 | |||
| if (versionDetails.version < "6.2.0" && platformDetails.operatingSystem !== OperatingSystem.Windows) { | |||
| const msg = "Attaching to a PowerShell Host Process is supported only on Windows."; | |||
There was a problem hiding this comment.
Seems like we should change this message to indicate it's is supported on Windows and PowerShell Core >= 6.2.0.
There was a problem hiding this comment.
wow duh. Thoughts on this?
Suggested change
| const msg = "Attaching to a PowerShell Host Process is supported only on Windows."; | |
| const msg = "Attaching to a PowerShell Host Process is supported on Windows and PowerShell Core 6.2 and up on Non-Windows."; |
There was a problem hiding this comment.
How about this instead:
Attaching to a PowerShell Host Process on ${osName} requires PowerShell 6.2 or higher.
|
Proof: |
rjmholt
approved these changes
Jan 30, 2019
TylerLeonhardt
added a commit
that referenced
this pull request
Feb 2, 2019
* turn off non-windows gate for attach to process * address feedback * no single quotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
As of 6.2.0-preview.4
Enter-PSHostProcessandGet-PSHostProcessInfoboth work on Non-Windows so I've modified the check to allow folks with 6.2.0 and higher to use the Attach to process debug config.We try to only support the latest preview of PowerShell since it gets hairy to maintain all of the previews... if you feel like I should make the check more robust, let me know! However, I don't know the % of people who would be on preview.X and try using Enter-PSHostProcess.
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready