Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug finding Windows PowerShell #2252

Merged

Conversation

rjmholt
Copy link
Collaborator

@rjmholt rjmholt commented Oct 23, 2019

PR Summary

Fixes the issue where the extension won't start when PowerShell Core is not present.

This is the minimal "backport" of #2238.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TylerLeonhardt
Copy link
Member

We should probably do a stable release soon because of this and the script analyzer regression (or was that in preview?)

@TylerLeonhardt TylerLeonhardt merged commit 12e15ad into PowerShell:legacy/1.x Oct 25, 2019
@rjmholt rjmholt deleted the backport/fix-winps-startup branch December 11, 2019 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants