feat: add events #30
feat: add events #30
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey! contributor, thank you for opening a Pull Request 🎉.
Soon one of our maintainers will review it and provide you with feedback/suggestions. If you think it's something urgent, feel free to reach out Pradumna Saraf on Twitter. Star ⭐ this repo to show us support.
Happy, Open Source!
|
Hey, Thanks for the PR. About the issue. We should then go with talking the complete input from the user because this format might not work with the LinkFree, so there is a risk. Also, it will become simpler for us as well to handle, with no internal conversion Later we can try to come up with some solution using some tool or API. For now, we can just put the sample format in the bracket when we prompt the message for data. What is your take on this? |
But isn't this difficult for a user to give because the date is fine but after that the timestamp part is something that the user should understand before writing anything |
I agree with you 100%. This is why when we discussed about this, I said we need to make it easier at the user end (convert internally). But we have no option. We can't make JSON in the wrong format which will not work with LinkFree. |
Let me do one thing only the Z part at the end has to be replaced with something like +00:00 so I think I will keep this as default for now and later we can come up with a solution |
Din't get you |
|
|
|
Sure, you can have a look. But I suggest going with complete user input because date and time things are tricky. |
|
Also, we are taking only the date as the input, not the time. That means time will always be 0 (i.e event will start mid night) |
|
Fine I think I will make the changes like I suggested before as time doesn't really matter that much |
No, it matters because we are adding events to the map which requires time to show nearby conferences happening at a given time. |
|
Okayyy that's a problem. Fine I will keep it as user input then. |
|
Hey @Pradumnasaraf you can review the PR now. I have kept the date input completely upto user. No internal conversions done. |
There was a problem hiding this comment.
Hey, thanks for the changes. It's working great.
Small suggestions
In the prompt, we should add a little clear message that we are expecting both a date and time and also a sample for ease. Something like this
- message: "Give event start date",
+ message: "Give event start date and time. (Supported format: 2023-08-09T00:00:00.000+00:00),
|
Done the changes @Pradumnasaraf |
No worries. |
|
Should we merge it? |
yeah go ahead |
|
Done Amazing. All 4 major parts are done. Feels good and happy :) |
Yeah finally. I think we have to just look into some small fixes here and there and then we are good to go! |
Yep, 100%. BTW a small shout out to you again. If you haven't opened the issues on the repo. I didn't move ahead and collaborate with you to fix this, I was not planning to do the CLI right now and even not 2.0.0. Just 1.5.0
|
Thanks for saying that @Pradumnasaraf and I am also happy to work alongside you on this project. It was really fun. Kudos to u too for being a great maintainer 👍 |
|
Thank you. I learned a lot from you. About structuring and code. |
Me too. I never worked on a cli tool before so it was nice to have a project that was easy to work with. |
Oh wow, I didn't know this was your 1st time on a CLI. Your contributors were huge 👏 |
haha fake it till u make it. I have learned that with time. |
|
Also, forgot to ask you before, would you like to be a Maintainer? |
Ohhh yessss I would love to. Thanks for asking @Pradumnasaraf This is an amazing project and I would love to be a part of it. 😁 |
|
No, thank you for accepting. Sent you an invite :). |
Accepted! 😀 |
|
Awesome. Welcome 🎉 . This is the 1st time, I onboarded a maintainer on one of my projects. |
Congrats to u too then 👏 |
Thank you. |
👨💻 Changes proposed
Created addEvents function
📄 Note to reviewers
Hey @Pradumnasaraf. I created the addEvents function. But there is one small issue that the date format is not the same as we want. After converting it into a date object we are getting something like this:
2023-08-09T00:00:00.000Zbut it should be like this2023-08-09T00:00:00.000+00:00instead.