This repository has been archived by the owner on Feb 19, 2024. It is now read-only.
From Callback to Promise - TabCorp - 26/04/2017 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtramontina
reviewed
Apr 28, 2017
|
|
||
| ```coffeescript | ||
| it 'does something', -> | ||
| myObject.myPromise(parameter).then -> |
There was a problem hiding this comment.
Maybe it is worth mentioning that you have to return a promise on a mocha test so it waits for the promise's resolution… and because of coffee-script, we don't need an explicit return on the last statement…
gtramontina
reviewed
Apr 28, 2017
from-callback-to-promise/README.md
Outdated
|
|
||
| again, we don't need to use `done` and we don't need to write an expectation for `err` object since inside `.then` we don't have an error. | ||
|
|
||
| 3. In the implementation side, we can try always to write our promises in a way that it tells us an story: |
There was a problem hiding this comment.
Perhaps add something along these lines: "aiming to have one-liners; extract functions and give them descriptive names"… 💭?
rodolfoprr
force-pushed
the
from-callback-to-promise
branch
from
a8567df
to
edd9a3e
Compare
gtramontina
approved these changes
May 1, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushing some lessons learned in the last two sessions since we can share the code in this repository. Am I missing anything important? 😛
@gtramontina @ronaldotijucas @yeahyangliu @ReenaRajani @gaurav-narra