Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Dockerfile #1

Closed
2 of 3 tasks
buep opened this issue Mar 20, 2018 · 6 comments
Closed
2 of 3 tasks

Create Dockerfile #1

buep opened this issue Mar 20, 2018 · 6 comments

Comments

@buep
Copy link

buep commented Mar 20, 2018

##- [x] Bases on default Jenkins docker hub image

@buep
Copy link
Author

buep commented Mar 20, 2018

Related to Praqma/praqma-jenkins-casc#8

@buep buep added this to the Workable milestone Mar 20, 2018
@MadsNielsen
Copy link
Member

MadsNielsen commented Mar 23, 2018

Ok, I've started work on this. I've setup autobuild for the this project on dockerhub. Autobuild is configured to build the image with latest docker tag from commits on master. Git tags will be labelled with the same name as the tag.

Suggest to follow the pattern: The tag will be the same as the version of the included Configuration as Code plugin. So for instance, the first version, when it's ready will be the full name praqma/jenkins4casc:0.2-alpha.

MadsNielsen added a commit that referenced this issue Mar 23, 2018
MadsNielsen added a commit that referenced this issue Mar 23, 2018
MadsNielsen added a commit that referenced this issue Mar 23, 2018
MadsNielsen added a commit that referenced this issue Mar 23, 2018
MadsNielsen added a commit that referenced this issue Mar 23, 2018
MadsNielsen added a commit that referenced this issue Mar 23, 2018
@buep
Copy link
Author

buep commented Mar 23, 2018

Suggest to follow the pattern: The tag will be the same as the version of the included Configuration as Code plugin. So for instance, the first version, when it's ready will be the full name praqma/jenkins4casc:0.2-alpha.

Fine, just write the release process and versijon strategi in the readme

MadsNielsen added a commit that referenced this issue Mar 23, 2018
@buep
Copy link
Author

buep commented Mar 26, 2018

That's fine. Btw....im not too sure on #1 the last point is for me not a good idea. Should our image not always select a specific version?

1 reply
bue.petersen [< 1 minute ago]
Yes, indeed, that is also what I mean... as in not referring to latest but a specific version as you suggest.

For now it means we will need to update the version in the dockerfile by hand, but you can make a new issue for the backlog on automating the process, so when a new casc plugin is released, we automatically bump the version used in dockerfile, commit, push and build and test tit.

@MadsNielsen
Copy link
Member

The last part of this issue is desribed in #5

@MadsNielsen
Copy link
Member

Closing this. The remainder of this has been placed in #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants