Feature: Support mattermost notifier #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrasadG193
reviewed
May 21, 2021
search.go
Outdated
| if res.StatusCode != 200 { | ||
| return errors.New("Auth failure") | ||
| } | ||
| direct, res := client.CreateDirectChannel(user.Id, os.Getenv("MATTERMOST_USER_ID")) |
There was a problem hiding this comment.
same here, it should be possible to provide userID as a CLI flag
README.md
Outdated
| #### Notifications to mattermost | ||
|
|
||
| ``` | ||
| ATTERMOST_URL="<mattermost url>" MATTERMOST_API_TOKEN="<mattermost bot api token>" MATTERMOST_USER_ID="<mattermost user id>" ./covaccine-notifier --state Maharashtra --district Akola --age 27 -n mattermost |
There was a problem hiding this comment.
Please add an example with CLI flags. It should be possible to provide Mattermost creds with CLI args
|
@frezbo Please run |
|
FYI, I am working on refactoring notifier interface. We might need to do some changes accordingly |
|
I'll create a new PR once #33 is merged. So that I can rebase based on the new notifier interface. Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Noel Georgi git@frezbo.dev