Fix for CustomKnight not working in MoreSaves's additional save files. #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Affects the system to load skins associated with a specific file slot. Fixes the bug of CustomKnight not working with MoreSaves in files past the default 4. Stores skins associated with each slot as a Dictionary rather than an Array, with the slot number (starting from 0 to be consistent with existing array calls) being the key value and returning the relevant skin. If a save slot is loaded that does not currently have an entry in the Dictionary, it will be given the appropriate entry.
Affects the system to load skins associated with a specific file slot. Fixes the bug of CustomKnight not working with MoreSaves in files past the default 4. Stores skins associated with each slot as a Dictionary rather than an Array, with the slot number (starting from 0 to be consistent with existing array calls) being the key value and returning the relevant skin. If a save slot is loaded that does not currently have an entry in the Dictionary, it will be given the appropriate entry.
This reverts commit 09ed868.
Affects the system to load skins associated with a specific file slot. Fixes the bug of CustomKnight not working with MoreSaves in files past the default 4. Stores skins associated with each slot as a Dictionary rather than an Array, with the slot number (starting from 0 to be consistent with existing array calls) being the key value and returning the relevant skin. If a save slot is loaded that does not currently have an entry in the Dictionary, it will be given the appropriate entry. Should have minimal impact on play without MoreSaves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug where CustomKnight doesn't work in saves past slot four by swapping the array that associates skins with a specific save slot (saveSkins) for a dictionary with integer keys (starting from 0 to keep compatibility with existing array calls). If a file is loaded that does not have an entry in the dictionary, it is given one.
In my own testing this fix works cleanly. All four base slots work fine, and doing weird stuff like loading slot 7 without ever loading 5 seems to work as well as it should. Skins are loaded and saved appropriately.
(Commits are a bit of a mess. It's my first time working with GitHub.)