Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_alembic_version done synchronously #286

Merged
merged 7 commits into from
May 9, 2023

Conversation

aaazzam
Copy link
Collaborator

@aaazzam aaazzam commented May 9, 2023

Make infra.database.check_alembic_version synchronous and rm awaits.

also removes alembic logging configuration

AFAICT a race condition was introduced between alembic and prefect's attempt to acquire a log lock

# Interpret the config file for Python logging.
# This line sets up loggers basically.
# if config.config_file_name is not None:
#     fileConfig(config.config_file_name, disable_existing_loggers=False)

@zzstoatzz zzstoatzz requested a review from jlowin May 9, 2023 19:33
@zzstoatzz zzstoatzz merged commit 127128b into main May 9, 2023
@zzstoatzz zzstoatzz deleted the syncronously_check_alembic_version branch May 9, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants