Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracebacks should be logged #1374

Closed
cicdw opened this issue Aug 17, 2019 · 0 comments · Fixed by #1382
Closed

Tracebacks should be logged #1374

cicdw opened this issue Aug 17, 2019 · 0 comments · Fixed by #1382
Assignees

Comments

@cicdw
Copy link
Member

cicdw commented Aug 17, 2019

When unexpected errors occur, we currently only log the repr of the caught exception. I propose that we should begin logging tracebacks for better visibility into issues. To do so requires two steps:

  • begin logging caught exceptions with logger.exception(msg) (this will require a full audit; some caught exceptions are currently being logged as "INFO", others as "DEBUG")
  • in the CloudHandler itself, include traceback text by:
if record.exc_text is not None:
    record.message += "\n" + record.exc_text
@cicdw cicdw self-assigned this Aug 19, 2019
@cicdw cicdw mentioned this issue Aug 20, 2019
3 tasks
zanieb added a commit that referenced this issue Mar 17, 2022
Add network mode inference to docker flow runner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant