Refining how we validate flow parameters under Pydantic 1 versus 2 #11028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have seen a few edge cases popping up where we're trying to use the pydantic v2 validator to validate v1 models as flow function arguments. This leads to the opaque error: ``` TypeError: BaseModel.validate() takes 2 positional arguments but 3 were given ``` Examples: * PrefectHQ/prefect-airbyte#61 * https://github.com/PrefectHQ/prefect-kubernetes/actions/runs/6628004996/job/18004160832?pr=92 The issue here is that we were trying to use our custom v2 port of the v1 `ValidatedFunction`, without inspecting the types of models involved. Here, we are looking at the types of the passed arguments, validating that they aren't mixing v1 and v2 models, and then choosing the right validation implementation from there.
✅ Deploy Preview for prefect-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
urimandujano
approved these changes
Oct 25, 2023
|
Yep I think this is popping up in our collections libraries because they have flows that are passing blocks around as parameters, and the blocks are ultimately derived from v1 base models (for now). |
|
FWIW, I also tested this with an editable local install in our |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have seen a few edge cases popping up where we're trying to use the
pydantic v2 validator to validate v1 models as flow function arguments. This
leads to the opaque error:
Examples:
The issue here is that we were trying to use our custom v2 port of the v1
ValidatedFunction, without inspecting the types of models involved. Here, weare looking at the types of the passed arguments, validating that they aren't
mixing v1 and v2 models, and then choosing the right validation implementation
from there.