[task scheduling] scope TaskRunner to TaskServer
#11806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-server-task-runner
The goal here is for each subscriber to be able to filter to a subset of the tasks they are interested in (i.e. which tasks a task server is serving). This required routing task runs into queues and monitoring multiple queues for tasks. This was a good opportunity to refactor some of the mechanics here to capture the idea that a `TaskQueue` is really two queues (a "regular" queue and a high-priority retry queue). This led me down a path of tidying up the implementation to remove globals and encapsulate more of the behavior.
✅ Deploy Preview for prefect-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…-server-task-runner
…Q/prefect into task-server-task-runner
…ectHQ/prefect into task-server-task-runner
…Q/prefect into task-server-task-runner
zzstoatzz
commented
Feb 2, 2024
| create_autonomous_task_run | ||
| ) | ||
| else: | ||
| return from_sync.wait_for_call_in_loop_thread( |
There was a problem hiding this comment.
this part handles the sync within async correctly where sync_compatible does not
chrisguidry
approved these changes
Feb 2, 2024
src/prefect/context.py
Outdated
| @@ -234,9 +233,9 @@ class EngineContext(RunContext): | |||
| flow: Optional["Flow"] = None | |||
| flow_run: Optional[FlowRun] = None | |||
| autonomous_task_run: Optional[TaskRun] = None | |||
| task_runner: BaseTaskRunner | |||
| task_runner: Any | |||
There was a problem hiding this comment.
Is it really Any or is it Optional[BaseTaskRunner]?
There was a problem hiding this comment.
i was slightly over-complicating this in the case where we want to re-use a task runner, we can just pass the task runner instance along instead of entering a null context and then the typing stays the same
updated in 1a5a047
src/prefect/task_server.py
Outdated
| - tags: A list of tags to apply to the task server. Defaults to `["autonomous"]`. | ||
| - task_runner: The task runner to use for executing the tasks. Defaults to | ||
| `ConcurrentTaskRunner`. | ||
| - tags: A list of tags to add to task runs submitted by the task server. |
There was a problem hiding this comment.
Are we still doing the tags thing? The TaskServer doesn't submit tasks anymore, right?
There was a problem hiding this comment.
ahh i see what you mean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR:
task_runnerviaserve(to be used for all task runs picked up by thatTaskServer)TaskServercontext management, in particular to make sure we only start / stop aTaskRunnerwith the lifetime of theTaskServer(i.e. not once per task submission)stacked on top of #11805, so will not merge until that is