Vendoring starlette@0.33.0 #11956
Merged
Vendoring starlette@0.33.0 #11956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent security vulnerability was identified in [`starlette` versions below 0.36.2](GHSA-93gm-qmq6-w238). We can't upgrade our version of `starlette` at the current time, because it's not compatible with our vendored version of `fastapi`. However, the change in starlette is simply to set a lower-bound on `python-multipart`, so that's included here as well. However, I'm still vendoring `starlette` because our upper bound pin is preventing other users from upgrading their dependencies. Once our deprecation period for `pydantic<2` has passed, we can drop both vendored libraries and go back to the public versions. Note that I'm removing `black` from our pre-commit config, because we are using `ruff` exclusively. `black` had some trouble with formatting these files from `starlette`, which made me realize it shouldn't be in play anymore. Fixes #11719
✅ Deploy Preview for prefect-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jakekaplan
approved these changes
Feb 9, 2024
|
Do all the internal references need to change to avoid things like: or we just need to change how we install it |
|
Sorry, I did a last minute tweak to the vendoring script and mistakenly botched the import fixes :D Just pushed a fixed version up |
zzstoatzz
reviewed
Feb 9, 2024
Comment on lines
5
to
7
| - id: ruff | ||
| language_version: python3 | ||
| args: [--fix, --exit-non-zero-on-fix, --show-fixes] |
There was a problem hiding this comment.
ruff format is pretty great imo if we're nixing black
Suggested change
| - id: ruff | |
| language_version: python3 | |
| args: [--fix, --exit-non-zero-on-fix, --show-fixes] | |
| - id: ruff-format | |
| - id: ruff | |
| language_version: python3 | |
| args: [--fix, --exit-non-zero-on-fix, --show-fixes] |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent security vulnerability was identified in
starletteversions below0.36.2. We can't upgrade
our version of
starletteat the current time, because it's not compatible withour vendored version of
fastapi. However, the change in starlette is simplyto set a lower-bound on
python-multipart, so that's included here as well.However, I'm still vendoring
starlettebecause our upper bound pin ispreventing other users from upgrading their dependencies.
Once our deprecation period for
pydantic<2has passed, we can drop bothvendored libraries and go back to the public versions.
Note that I'm removing
blackfrom our pre-commit config, because we are usingruffexclusively.blackhad some trouble with formatting these files fromstarlette, which made me realize it shouldn't be in play anymore.Fixes #11719