Flow with_options fixes - retries, retry_delay_seconds, flow_run_name

[NodeJSmith]

Closes #11468

Correct logic in Flow.with_options to allow setting retries and retry_delay_seconds to 0.

Checklist

• This pull request references any related issue by including "closes <link to issue>"
  • If no issue exists and your change is not a small fix, please create an issue first.
• This pull request includes tests or only affects documentation.
• This pull request includes a label categorizing the change e.g. maintenance, fix, feature, enhancement, docs.

For documentation changes:

• This pull request includes redirect settings in netlify.toml for files that are removed or renamed.

For new functions or classes in the Python SDK:

• This pull request includes helpful docstrings.
• If a new Python file was added, this pull request contains a stub page in the Python SDK docs and an entry in mkdocs.yml navigation.

[netlify]

👷 Deploy request for prefect-docs-preview pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	518e792

[desertaxle]

Thanks for the PR @NodeJSmith! Could you please add one or two regression tests covering these changes?

[bunchesofdonald]

@NodeJSmith thank you for the pull request! The code here looks right to me, and I love that you fixed the type hint as well. I have one ask, could you add these options to this existing test? https://github.com/PrefectHQ/prefect/blob/main/tests/test_flows.py#L272

[NodeJSmith]

@bunchesofdonald Thanks for pointing out where to add these, I had meant to do that before creating the PR, I think it slipped my mind. Two tests added, one for each of the attributes. I double checked on the logic, since the timeout_seconds override test asserts that timeout_seconds gets set to None, not 0. I think the logic is sound though, the retries/retry_delay_seconds are just a bit different from the timeout_seconds as far as how they are set in the __init__ method.

Let me know if you have any other concerns or if I need to add anything else.

[NodeJSmith]

@bunchesofdonald I just realized while working on something that flow_run_name doesn't follow the convention of taking the value from the original Flow if not provided to with_options. Is this by design? If not I'm happy to add that to this PR

[bunchesofdonald]

@bunchesofdonald I just realized while working on something that flow_run_name doesn't follow the convention of taking the value from the original Flow if not provided to with_options. Is this by design? If not I'm happy to add that to this PR

I don't believe that was by design, so if you want to make this PR include that as well that seems fine to me.

Also don't worry about these test failures, httpx released a new version and we're dealing with some deprecation warnings.

[NodeJSmith]

@bunchesofdonald Ready for review again, fixed the flow_run_name argument and added a test validating the behavior

[bunchesofdonald]

This is great, thank you @NodeJSmith!

[desertaxle]

LGTM!