Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use explicit keywords for parameters and variables #1259

Merged
merged 4 commits into from
Jul 24, 2019
Merged

Use explicit keywords for parameters and variables #1259

merged 4 commits into from
Jul 24, 2019

Conversation

jlowin
Copy link
Member

@jlowin jlowin commented Jul 22, 2019

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

prefect.Client.graphql() accepted **variables for GraphQL variables, which was convenient when it didn't accept any other kwargs, but increasingly messy. This PR requires a single variables= kwarg.

@codecov
Copy link

codecov bot commented Jul 22, 2019

Codecov Report

Merging #1259 into master will increase coverage by 0.01%.
The diff coverage is 57.14%.

Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jlowin jlowin merged commit dbb483f into master Jul 24, 2019
@jlowin jlowin deleted the client branch July 24, 2019 00:10
abrookins pushed a commit that referenced this pull request Mar 15, 2022
BugFix: Hide placeholder text if the filter bar is disabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants